[clang codegen] Address review comment on comment in constWithPadding.

efriedma-quic · efriedma-quic · commit c46a0c07a634 · 2020-03-25T10:58:03.000-07:00
diff --git a/clang/lib/CodeGen/CGDecl.cpp b/clang/lib/CodeGen/CGDecl.cpp
@@ -1075,7 +1075,9 @@ static llvm::Constant *constWithPadding(CodeGenModule &CGM, IsPattern isPattern,
     auto *NewArrayTy = llvm::ArrayType::get(NewElemTy, Size);
     return llvm::ConstantArray::get(NewArrayTy, Values);
   }
-  // FIXME: Do we need to handle tail padding in vectors?
+  // FIXME: Add handling for tail padding in vectors. Vectors don't
+  // have padding between or inside elements, but the total amount of
+  // data can be less than the allocated size.
   return constant;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1075,7 +1075,9 @@ static llvm::Constant *constWithPadding(CodeGenModule &CGM, IsPattern isPattern,`
`1075`	`1075`	`auto *NewArrayTy = llvm::ArrayType::get(NewElemTy, Size);`
`1076`	`1076`	`return llvm::ConstantArray::get(NewArrayTy, Values);`
`1077`	`1077`	`}`
`1078`		`- // FIXME: Do we need to handle tail padding in vectors?`
	`1078`	`+ // FIXME: Add handling for tail padding in vectors. Vectors don't`
	`1079`	`+ // have padding between or inside elements, but the total amount of`
	`1080`	`+ // data can be less than the allocated size.`
`1079`	`1081`	`return constant;`
`1080`	`1082`	`}`
`1081`	`1083`