Skip to content

Commit 6e36981

Browse files
tglsfdctglsfdc
committed
Reject system columns as elements of foreign keys.
Up through v11 it was sensible to use the "oid" system column as a foreign key column, but since that was removed there's no visible usefulness in making any of the remaining system columns a foreign key. Moreover, since the TupleTableSlot rewrites in v12, such cases actively fail because of implicit assumptions that only user columns appear in foreign keys. The lack of complaints about that seems like good evidence that no one is trying to do it. Hence, rather than trying to repair those assumptions (of which there are at least two, maybe more), let's just forbid the case up front. Per this patch, a system column in either the referenced or referencing side of a foreign key will draw this error; however, putting one in the referenced side would have failed later anyway, since we don't allow unique indexes to be made on system columns. Per bug #17877 from Alexander Lakhin. Back-patch to v12; the case still appears to work in v11, so we shouldn't break it there. Discussion: https://postgr.es/m/17877-4bcc658e33df6de1@postgresql.org
1 parent 6f7ca62 commit 6e36981

File tree

3 files changed

+23
-10
lines changed

3 files changed

+23
-10
lines changed

‎src/backend/commands/tablecmds.c

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11260,6 +11260,11 @@ ATExecValidateConstraint(List **wqueue, Relation rel, char *constrName,
1126011260
* transformColumnNameList - transform list of column names
1126111261
*
1126211262
* Lookup each name and return its attnum and, optionally, type OID
11263+
*
11264+
* Note: the name of this function suggests that it's general-purpose,
11265+
* but actually it's only used to look up names appearing in foreign-key
11266+
* clauses. The error messages would need work to use it in other cases,
11267+
* and perhaps the validity checks as well.
1126311268
*/
1126411269
static int
1126511270
transformColumnNameList(Oid relId, List *colList,
@@ -11273,21 +11278,27 @@ transformColumnNameList(Oid relId, List *colList,
1127311278
{
1127411279
char *attname = strVal(lfirst(l));
1127511280
HeapTuple atttuple;
11281+
Form_pg_attribute attform;
1127611282

1127711283
atttuple = SearchSysCacheAttName(relId, attname);
1127811284
if (!HeapTupleIsValid(atttuple))
1127911285
ereport(ERROR,
1128011286
(errcode(ERRCODE_UNDEFINED_COLUMN),
1128111287
errmsg("column \"%s\" referenced in foreign key constraint does not exist",
1128211288
attname)));
11289+
attform = (Form_pg_attribute) GETSTRUCT(atttuple);
11290+
if (attform->attnum < 0)
11291+
ereport(ERROR,
11292+
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
11293+
errmsg("system columns cannot be used in foreign keys")));
1128311294
if (attnum >= INDEX_MAX_KEYS)
1128411295
ereport(ERROR,
1128511296
(errcode(ERRCODE_TOO_MANY_COLUMNS),
1128611297
errmsg("cannot have more than %d keys in a foreign key",
1128711298
INDEX_MAX_KEYS)));
11288-
attnums[attnum] = ((Form_pg_attribute) GETSTRUCT(atttuple))->attnum;
11299+
attnums[attnum] = attform->attnum;
1128911300
if (atttypids != NULL)
11290-
atttypids[attnum] = ((Form_pg_attribute) GETSTRUCT(atttuple))->atttypid;
11301+
atttypids[attnum] = attform->atttypid;
1129111302
ReleaseSysCache(atttuple);
1129211303
attnum++;
1129311304
}

‎src/test/regress/expected/foreign_key.out

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -795,15 +795,16 @@ SELECT * FROM FKTABLE ORDER BY id;
795795

796796
DROP TABLE FKTABLE;
797797
DROP TABLE PKTABLE;
798-
CREATE TABLE PKTABLE (ptest1 int PRIMARY KEY);
798+
-- Test some invalid FK definitions
799+
CREATE TABLE PKTABLE (ptest1 int PRIMARY KEY, someoid oid);
799800
CREATE TABLE FKTABLE_FAIL1 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (ftest2) REFERENCES PKTABLE);
800801
ERROR: column "ftest2" referenced in foreign key constraint does not exist
801802
CREATE TABLE FKTABLE_FAIL2 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (ftest1) REFERENCES PKTABLE(ptest2));
802803
ERROR: column "ptest2" referenced in foreign key constraint does not exist
803-
DROP TABLE FKTABLE_FAIL1;
804-
ERROR: table "fktable_fail1" does not exist
805-
DROP TABLE FKTABLE_FAIL2;
806-
ERROR: table "fktable_fail2" does not exist
804+
CREATE TABLE FKTABLE_FAIL3 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (tableoid) REFERENCES PKTABLE(someoid));
805+
ERROR: system columns cannot be used in foreign keys
806+
CREATE TABLE FKTABLE_FAIL4 ( ftest1 oid, CONSTRAINT fkfail1 FOREIGN KEY (ftest1) REFERENCES PKTABLE(tableoid));
807+
ERROR: system columns cannot be used in foreign keys
807808
DROP TABLE PKTABLE;
808809
-- Test for referencing column number smaller than referenced constraint
809810
CREATE TABLE PKTABLE (ptest1 int, ptest2 int, UNIQUE(ptest1, ptest2));

‎src/test/regress/sql/foreign_key.sql

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -490,12 +490,13 @@ SELECT * FROM FKTABLE ORDER BY id;
490490
DROP TABLE FKTABLE;
491491
DROP TABLE PKTABLE;
492492

493-
CREATE TABLE PKTABLE (ptest1 int PRIMARY KEY);
493+
-- Test some invalid FK definitions
494+
CREATE TABLE PKTABLE (ptest1 int PRIMARY KEY, someoid oid);
494495
CREATE TABLE FKTABLE_FAIL1 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (ftest2) REFERENCES PKTABLE);
495496
CREATE TABLE FKTABLE_FAIL2 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (ftest1) REFERENCES PKTABLE(ptest2));
497+
CREATE TABLE FKTABLE_FAIL3 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (tableoid) REFERENCES PKTABLE(someoid));
498+
CREATE TABLE FKTABLE_FAIL4 ( ftest1 oid, CONSTRAINT fkfail1 FOREIGN KEY (ftest1) REFERENCES PKTABLE(tableoid));
496499

497-
DROP TABLE FKTABLE_FAIL1;
498-
DROP TABLE FKTABLE_FAIL2;
499500
DROP TABLE PKTABLE;
500501

501502
-- Test for referencing column number smaller than referenced constraint

0 commit comments

Comments
 (0)