Drop test view when done with it.

tglsfdc · tglsfdc · commit b15db7f6905a · 2023-02-27T20:27:48.000-05:00
The view just added by commit 53fe7e6 decompiles differently in v15 than HEAD (presumably as a consequence of 47bb9db). That causes failures in cross-version upgrade testing. We could teach AdjustUpgrade.pm to compensate for that, but it seems less painful to just drop the view after we're done with it. Per buildfarm.
diff --git a/contrib/postgres_fdw/expected/postgres_fdw.out b/contrib/postgres_fdw/expected/postgres_fdw.out
@@ -11473,6 +11473,9 @@ SELECT count(*) FROM remote_application_name
      1
 (1 row)
 
+-- Clean up.
+DROP FOREIGN TABLE remote_application_name;
+DROP VIEW my_application_name;
 -- ===================================================================
 -- test parallel commit
 -- ===================================================================
diff --git a/contrib/postgres_fdw/sql/postgres_fdw.sql b/contrib/postgres_fdw/sql/postgres_fdw.sql
@@ -3719,6 +3719,10 @@ SELECT count(*) FROM remote_application_name
       to_hex(pg_backend_pid())
       for current_setting('max_identifier_length')::int);
 
+-- Clean up.
+DROP FOREIGN TABLE remote_application_name;
+DROP VIEW my_application_name;
+
 -- ===================================================================
 -- test parallel commit
 -- ===================================================================

Original file line number	Diff line number	Diff line change
`@@ -11473,6 +11473,9 @@ SELECT count(*) FROM remote_application_name`
`11473`	`11473`	`1`
`11474`	`11474`	`(1 row)`
`11475`	`11475`
	`11476`	`+-- Clean up.`
	`11477`	`+DROP FOREIGN TABLE remote_application_name;`
	`11478`	`+DROP VIEW my_application_name;`
`11476`	`11479`	`-- ===================================================================`
`11477`	`11480`	`-- test parallel commit`
`11478`	`11481`	`-- ===================================================================`