Skip to content

Commit d1d0fe1

Browse files
committed
Stabilize 039_end_of_wal test.
The first test was sensitive to the insert LSN after setting up the catalogs, which depended on environmental things like the locales on the OS and usernames. Switch to a new WAL file before the first test, as a simple way to put every computer into the same state. Back-patch to all supported releases. Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru> Reported-by: Nathan Bossart <nathandbossart@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Nathan Bossart <nathandbossart@gmail.com> Discussion: https://postgr.es/m/b26aeac2-cb6d-4633-a7ea-945baae83dcf%40postgrespro.ru
1 parent 187d8bb commit d1d0fe1

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/test/recovery/t/039_end_of_wal.pl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,12 @@ sub advance_to_record_splitting_zone
257257
$TLI = $node->safe_psql('postgres',
258258
"SELECT timeline_id FROM pg_control_checkpoint();");
259259

260+
# Initial LSN may vary across systems due to different catalog contents set up
261+
# by initdb. Switch to a new WAL file so all systems start out in the same
262+
# place. The first test depends on trailing zeroes on a page with a valid
263+
# header.
264+
$node->safe_psql('postgres', "SELECT pg_switch_wal();");
265+
260266
my $end_lsn;
261267
my $prev_lsn;
262268

0 commit comments

Comments
 (0)