Improved code

ankane · ankane · commit f4e6440b0c16 · 2024-10-19T15:37:16.000-07:00
diff --git a/src/bit.rs b/src/bit.rs
@@ -19,7 +19,7 @@ impl Bit {
         let len = data.len();
         let mut bytes = vec![0; (len + 7) / 8];
         for (i, v) in data.iter().enumerate() {
-            bytes[i / 8] |= (*v as u8) << (7 - (i % 8));
+            bytes[i / 8] |= u8::from(*v) << (7 - (i % 8));
         }
         Bit { len, data: bytes }
     }
diff --git a/src/halfvec.rs b/src/halfvec.rs
@@ -39,7 +39,7 @@ impl HalfVector {
     pub(crate) fn from_sql(
         buf: &[u8],
     ) -> Result<HalfVector, Box<dyn std::error::Error + Sync + Send>> {
-        let dim = u16::from_be_bytes(buf[0..2].try_into()?) as usize;
+        let dim = u16::from_be_bytes(buf[0..2].try_into()?).into();
         let unused = u16::from_be_bytes(buf[2..4].try_into()?);
         if unused != 0 {
             return Err("expected unused to be 0".into());
diff --git a/src/vector.rs b/src/vector.rs
@@ -42,7 +42,7 @@ impl Vector {
 
     #[cfg(any(feature = "postgres", feature = "sqlx", feature = "diesel"))]
     pub(crate) fn from_sql(buf: &[u8]) -> Result<Vector, Box<dyn std::error::Error + Sync + Send>> {
-        let dim = u16::from_be_bytes(buf[0..2].try_into()?) as usize;
+        let dim = u16::from_be_bytes(buf[0..2].try_into()?).into();
         let unused = u16::from_be_bytes(buf[2..4].try_into()?);
         if unused != 0 {
             return Err("expected unused to be 0".into());
