modlte: improve exception texts

peter-pycom · peter-pycom · commit a641ac5e7f51 · 2020-11-23T18:18:44.000+01:00
diff --git a/esp32/mods/modlte.c b/esp32/mods/modlte.c
@@ -243,7 +243,7 @@ static void lte_pause_ppp(void) {
                     if (!lte_push_at_command("AT", LTE_RX_TIMEOUT_MIN_MS)) {
                         mp_hal_delay_ms(LTE_PPP_BACK_OFF_TIME_MS);
                         if (!lte_push_at_command("AT", LTE_RX_TIMEOUT_MIN_MS)) {
-                            nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, mpexception_os_operation_failed));
+                            nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, "Pause PPP failed"));
                         }
                     }
                 }
@@ -1174,13 +1174,13 @@ STATIC mp_obj_t lte_resume(mp_uint_t n_args, const mp_obj_t *pos_args, mp_map_t
     mp_arg_parse_all(n_args - 1, pos_args + 1, kw_args, MP_ARRAY_SIZE(allowed_args), allowed_args, args);
 
     if (lteppp_get_state() == E_LTE_PPP) {
-        nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, mpexception_os_request_not_possible));
+        nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, "Modem is already connected"));
     }
     lte_check_attached(lte_legacyattach_flag);
 
     if (lteppp_get_state() == E_LTE_SUSPENDED || lteppp_get_state() == E_LTE_ATTACHED) {
         if (lteppp_get_state() == E_LTE_ATTACHED && lteppp_get_legacy() == E_LTE_LEGACY) {
-            nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, mpexception_os_request_not_possible));
+            nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, "Operation failed (attached and legacy)"));
         }
 //        char at_cmd[LTE_AT_CMD_SIZE_MAX - 4];
         if (args[0].u_obj != mp_const_none) {

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ static void lte_pause_ppp(void) {`
`243`	`243`	`if (!lte_push_at_command("AT", LTE_RX_TIMEOUT_MIN_MS)) {`
`244`	`244`	`mp_hal_delay_ms(LTE_PPP_BACK_OFF_TIME_MS);`
`245`	`245`	`if (!lte_push_at_command("AT", LTE_RX_TIMEOUT_MIN_MS)) {`
`246`		`- nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, mpexception_os_operation_failed));`
	`246`	`+ nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, "Pause PPP failed"));`
`247`	`247`	`}`
`248`	`248`	`}`
`249`	`249`	`}`
`@@ -1174,13 +1174,13 @@ STATIC mp_obj_t lte_resume(mp_uint_t n_args, const mp_obj_t *pos_args, mp_map_t`
`1174`	`1174`	`mp_arg_parse_all(n_args - 1, pos_args + 1, kw_args, MP_ARRAY_SIZE(allowed_args), allowed_args, args);`
`1175`	`1175`
`1176`	`1176`	`if (lteppp_get_state() == E_LTE_PPP) {`
`1177`		`- nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, mpexception_os_request_not_possible));`
	`1177`	`+ nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, "Modem is already connected"));`
`1178`	`1178`	`}`
`1179`	`1179`	`lte_check_attached(lte_legacyattach_flag);`
`1180`	`1180`
`1181`	`1181`	`if (lteppp_get_state() == E_LTE_SUSPENDED \|\| lteppp_get_state() == E_LTE_ATTACHED) {`
`1182`	`1182`	`if (lteppp_get_state() == E_LTE_ATTACHED && lteppp_get_legacy() == E_LTE_LEGACY) {`
`1183`		`- nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, mpexception_os_request_not_possible));`
	`1183`	`+ nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, "Operation failed (attached and legacy)"));`
`1184`	`1184`	`}`
`1185`	`1185`	`// char at_cmd[LTE_AT_CMD_SIZE_MAX - 4];`
`1186`	`1186`	`if (args[0].u_obj != mp_const_none) {`