gh-137626: fix error messages of dict() and dict().update()

alex-semenyuk · alex-semenyuk · commit 1d95153a0752 · 2025-08-13T22:25:13.000+05:00
diff --git a/Lib/test/test_dict.py b/Lib/test/test_dict.py
@@ -28,6 +28,23 @@ def test_constructor(self):
         self.assertEqual(dict(), {})
         self.assertIsNot(dict(), {})
 
+    def test_constructor_positional_argument_error_messages(self):
+        with self.assertRaisesRegex(TypeError,
+                                   r"dict expected at most 1 positional argument, got 2"):
+            dict('John', 36)
+        with self.assertRaisesRegex(TypeError,
+                                   r"dict expected at most 1 positional argument, got 3"):
+            dict('a', 'b', 'c')
+
+    def test_update_positional_argument_error_messages(self):
+        d = {}
+        with self.assertRaisesRegex(TypeError,
+                                   r"update expected at most 1 positional argument, got 2"):
+            d.update('John', 36)
+        with self.assertRaisesRegex(TypeError,
+                                   r"update expected at most 1 positional argument, got 3"):
+            d.update('a', 'b', 'c')
+
     def test_literal_constructor(self):
         # check literal constructor for different sized dicts
         # (to exercise the BUILD_MAP oparg).
diff --git a/Python/getargs.c b/Python/getargs.c
@@ -2743,7 +2743,7 @@ _PyArg_CheckPositional(const char *name, Py_ssize_t nargs,
         if (name != NULL)
             PyErr_Format(
                 PyExc_TypeError,
-                "%.200s expected %s%zd argument%s, got %zd",
+                "%.200s expected %s%zd positional argument%s, got %zd",
                 name, (min == max ? "" : "at least "), min, min == 1 ? "" : "s", nargs);
         else
             PyErr_Format(
@@ -2762,7 +2762,7 @@ _PyArg_CheckPositional(const char *name, Py_ssize_t nargs,
         if (name != NULL)
             PyErr_Format(
                 PyExc_TypeError,
-                "%.200s expected %s%zd argument%s, got %zd",
+                "%.200s expected %s%zd positional argument%s, got %zd",
                 name, (min == max ? "" : "at most "), max, max == 1 ? "" : "s", nargs);
         else
             PyErr_Format(
