[3.14] gh-134970: Fix exception message in argparse module (GH-134971) (GH-134991)

miss-islington · mgorny · web-flow · commit df7247a3802f · 2025-06-01T06:21:34.000Z
Fix the "unknown action" exception in argparse.ArgumentParser.add_argument_group() to correctly replace the action class. (cherry picked from commit 965c480) Co-authored-by: Michał Górny <mgorny@gentoo.org>
diff --git a/Lib/argparse.py b/Lib/argparse.py
@@ -1534,7 +1534,7 @@ def add_argument(self, *args, **kwargs):
         action_name = kwargs.get('action')
         action_class = self._pop_action_class(kwargs)
         if not callable(action_class):
-            raise ValueError('unknown action {action_class!r}')
+            raise ValueError(f'unknown action {action_class!r}')
         action = action_class(**kwargs)
 
         # raise an error if action for positional argument does not
diff --git a/Misc/NEWS.d/next/Library/2025-05-31-12-08-12.gh-issue-134970.lgSaxq.rst b/Misc/NEWS.d/next/Library/2025-05-31-12-08-12.gh-issue-134970.lgSaxq.rst
@@ -0,0 +1,3 @@
+Fix the "unknown action" exception in
+:meth:`argparse.ArgumentParser.add_argument_group` to correctly replace the
+action class.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+Fix the "unknown action" exception in`
	`2`	+:meth:`argparse.ArgumentParser.add_argument_group` to correctly replace the
	`3`	`+action class.`