-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
Closed
Labels
3.14bugs and security fixesbugs and security fixesOS-windowsbuildThe build process and cross-buildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Bug report
Bug description:
Since PR #134211 / issue #133779 was packported to 3.14, Windows debug builds show more than thousand such warnings:
pyconfig.h(390,16): warning C4005: 'Py_DEBUG': macro redefinition
For example
- AMD64 Windows10 3.14: https://buildbot.python.org/#/builders/1711/builds/64
- AMD64 Windows11 Refleaks 3.14: https://buildbot.python.org/#/builders/1682/builds/33
- AMD64 Windows Server 2022 NoGIL 3.14: https://buildbot.python.org/#/builders/1717/builds/142
- AMD64 Windows11 Bigmem 3.14: https://buildbot.python.org/#/builders/1799/builds/86
This stems from
Lines 97 to 100 in b6e624a
/* _DEBUG implies Py_DEBUG */ | |
#ifdef _DEBUG | |
# define Py_DEBUG 1 | |
#endif |
which got added in the above PR, but rather belong to PR #131944 / issue #131942, which did not get backported, and should just be deleted.
CPython versions tested on:
3.14
Operating systems tested on:
Windows
Linked PRs
Metadata
Metadata
Assignees
Labels
3.14bugs and security fixesbugs and security fixesOS-windowsbuildThe build process and cross-buildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error