From 986354fb4201a52a55ec8d71e685ceb03a8e89b9 Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Fri, 6 Jun 2025 16:08:58 +0200 Subject: [PATCH] gh-134160: Use PyModuleDef.m_free in the example module xxlimited (GH-135174) (cherry picked from commit 1adca08d658ee2d520f3193960eaf3ae2ead1cef) Co-authored-by: Petr Viktorin Co-authored-by: neonene <53406459+neonene@users.noreply.github.com> --- Modules/xxlimited.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Modules/xxlimited.c b/Modules/xxlimited.c index d86741e1dfc18c..b29cd84d0b464b 100644 --- a/Modules/xxlimited.c +++ b/Modules/xxlimited.c @@ -417,6 +417,13 @@ xx_clear(PyObject *module) return 0; } +static void +xx_free(void *module) +{ + // allow xx_modexec to omit calling xx_clear on error + (void)xx_clear((PyObject *)module); +} + static struct PyModuleDef xxmodule = { PyModuleDef_HEAD_INIT, .m_name = "xxlimited", @@ -426,9 +433,7 @@ static struct PyModuleDef xxmodule = { .m_slots = xx_slots, .m_traverse = xx_traverse, .m_clear = xx_clear, - /* m_free is not necessary here: xx_clear clears all references, - * and the module state is deallocated along with the module. - */ + .m_free = xx_free, };