Support multi-arch builds in the devcontainer (#43)

brettcannon · web-flow · commit ff7f8f0c3e9b · 2025-05-29T14:48:34.000-07:00
Make WASI SDK and Wasmtime work under x86-64 and arm64.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -9,8 +9,12 @@ on:
 
 jobs:
   build_devcontainer:
-    name: Build (Devcontainer)
-    runs-on: ubuntu-latest
+    name: Build and test (Devcontainer)
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, ubuntu-24.04-arm]
+    runs-on: ${{ matrix.os }}
     env:
       TAG: cpython-devcontainer:1.0.0-${{ github.run_id }}
     steps:
@@ -24,6 +28,10 @@ jobs:
           context: ./devcontainer
           load: true
           tags: ${{ env.TAG }}
+      - name: Test WASI SDK
+        run: docker run --rm ${{ env.TAG }} /opt/wasi-sdk/bin/clang --version
+      - name: Test Wasmtime
+        run: docker run --rm ${{ env.TAG }} /usr/local/bin/wasmtime --version
 
   build_autoconf:
     name: Build and test (Autoconf)
diff --git a/devcontainer/Dockerfile b/devcontainer/Dockerfile
@@ -1,13 +1,9 @@
 FROM docker.io/library/fedora:41
 
-ENV CC=clang
+ARG TARGETARCH
 
-ENV WASI_SDK_VERSION=24
-ENV WASI_SDK_PATH=/opt/wasi-sdk
 
-ENV WASMTIME_HOME=/opt/wasmtime
-ENV WASMTIME_VERSION=22.0.0
-ENV WASMTIME_CPU_ARCH=x86_64
+ENV CC=clang
 
 RUN dnf -y --nodocs --setopt=install_weak_deps=False --disablerepo=fedora-cisco-openh264 install \
         /usr/bin/{blurb,clang,curl,git,ln,tar,xz} \
@@ -19,12 +15,32 @@ RUN dnf -y --nodocs --setopt=install_weak_deps=False --disablerepo=fedora-cisco-
         builddep python3 && \
     dnf -y clean all
 
+
+# Update only after consulting with WASI support maintainers (see PEP 11).
+ENV WASI_SDK_VERSION=24
+ENV WASI_SDK_PATH=/opt/wasi-sdk
+
 RUN mkdir ${WASI_SDK_PATH} && \
-    curl --location https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-${WASI_SDK_VERSION}/wasi-sdk-${WASI_SDK_VERSION}.0-x86_64-linux.tar.gz | \
+    case "${TARGETARCH}" in \
+        amd64) WASI_ARCH="x86_64" ;; \
+        arm64) WASI_ARCH="arm64" ;; \
+        *) echo "Unsupported TARGETARCH: ${TARGETARCH}" && exit 1 ;; \
+    esac && \
+    curl --location https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-${WASI_SDK_VERSION}/wasi-sdk-${WASI_SDK_VERSION}.0-${WASI_ARCH}-linux.tar.gz | \
     tar --strip-components 1 --directory ${WASI_SDK_PATH} --extract --gunzip
 
+
+# Update as desired.
+ENV WASMTIME_VERSION=33.0.0
+ENV WASMTIME_HOME=/opt/wasmtime
+
 RUN mkdir --parents ${WASMTIME_HOME} && \
-    curl --location "https://github.com/bytecodealliance/wasmtime/releases/download/v${WASMTIME_VERSION}/wasmtime-v${WASMTIME_VERSION}-${WASMTIME_CPU_ARCH}-linux.tar.xz" | \
+    case "${TARGETARCH}" in \
+        amd64) WASMTIME_ARCH="x86_64" ;; \
+        arm64) WASMTIME_ARCH="aarch64" ;; \
+        *) echo "Unsupported TARGETARCH: ${TARGETARCH}" && exit 1 ;; \
+    esac && \
+    curl --location "https://github.com/bytecodealliance/wasmtime/releases/download/v${WASMTIME_VERSION}/wasmtime-v${WASMTIME_VERSION}-${WASMTIME_ARCH}-linux.tar.xz" | \
     xz --decompress | \
     tar --strip-components 1 --directory ${WASMTIME_HOME} -x && \
     ln -s ${WASMTIME_HOME}/wasmtime /usr/local/bin
