Implement feedback from pull request

davidhalter · davidhalter · commit 485975cb22ca · 2025-08-12T09:07:07.000+02:00
diff --git a/conformance/results/mypy/qualifiers_annotated.toml b/conformance/results/mypy/qualifiers_annotated.toml
@@ -28,8 +28,6 @@ qualifiers_annotated.py:91: error: "<typing special form>" not callable  [operat
 qualifiers_annotated.py:92: error: "<typing special form>" not callable  [operator]
 qualifiers_annotated.py:98: error: Invalid type: ClassVar nested inside other type  [valid-type]
 qualifiers_annotated.py:100: error: Final can be only used as an outermost qualifier in a variable annotation  [valid-type]
-qualifiers_annotated.py:119: error: Cannot redefine "T" as a type variable  [misc]
-qualifiers_annotated.py:119: error: Invalid assignment target  [misc]
 """
 conformance_automated = "Fail"
 errors_diff = """
diff --git a/conformance/results/results.html b/conformance/results/results.html
@@ -256,7 +256,7 @@ <h3>Python Type System Conformance Test Results</h3>
 <th class="column col2 partially-conformant">Partial</th>
 <th class="column col2 conformant">Pass</th>
 <th class="column col2 not-conformant"><div class="hover-text">Unsupported<span class="tooltip-text" id="bottom"><p>Does not support generic defaults.</p></span></div></th>
-<th class="column col2 partially-conformant">Partial</th>
+<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not reject TypeVars with defaults after a TypeVarTuple</p><p>Type parameter defaults are not bound by attribute access</p><p>ParamSpec after TypeVarTuple is not always handled correctly</p></span></div></th>
 </tr>
 <tr><th class="column col1">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;generics_defaults_referential</th>
 <th class="column col2 partially-conformant">Partial</th>
diff --git a/conformance/results/zuban/generics_defaults.toml b/conformance/results/zuban/generics_defaults.toml
@@ -1,4 +1,9 @@
 conformant = "Partial"
+notes = """
+Does not reject TypeVars with defaults after a TypeVarTuple
+Type parameter defaults are not bound by attribute access
+ParamSpec after TypeVarTuple is not always handled correctly
+"""
 conformance_automated = "Fail"
 errors_diff = """
 Line 141: Expected 1 errors
diff --git a/conformance/results/zuban/qualifiers_annotated.toml b/conformance/results/zuban/qualifiers_annotated.toml
@@ -24,5 +24,4 @@ qualifiers_annotated.py:85: error: Argument 1 to "func4" has incompatible type "
 qualifiers_annotated.py:91: error: "_SpecialForm" not callable
 qualifiers_annotated.py:92: error: "_SpecialForm" not callable
 qualifiers_annotated.py:93: error: "<typing special form>" not callable
-qualifiers_annotated.py:119: error: Name "T" already defined on line 25
 """
diff --git a/conformance/src/type_checker.py b/conformance/src/type_checker.py
@@ -291,11 +291,6 @@ def install(self) -> bool:
                 [sys.executable, "-m", "pip", "install", "zuban"],
                 check=True,
             )
-
-            # Run "mypy --version" to ensure that it's installed and to work
-            # around timing issues caused by malware scanners on some systems.
-            self.get_version()
-
             return True
         except CalledProcessError:
             print("Unable to install zuban")
diff --git a/conformance/tests/qualifiers_annotated.py b/conformance/tests/qualifiers_annotated.py
@@ -115,7 +115,4 @@ class ClassC(TypedDict):
 
 TA1: TypeAlias = Annotated[int | str, ""]
 TA2 = Annotated[Literal[1, 2], ""]
-
-T = TypeVar("T")  # E?: T is already defined
-
 TA3 = Annotated[T, ""]
