Expose effective class construction params #1454
Draft
+378
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2541864 to
af0f118
Compare
470e2eb to
1edde23
Compare
Tinche
requested changes
Aug 10, 2025
| is_slotted: bool | ||
| has_weakref_slot: bool | ||
| is_frozen: bool | ||
| is_kw_only: bool |
There was a problem hiding this comment.
Can we combine these flags? We can't have force_kw_only without is_kw_only right?
There was a problem hiding this comment.
that is correct… so another Enum?
There was a problem hiding this comment.
Yes. I use literals for this in cattrs but that might be too modern for your tastes ;)
There was a problem hiding this comment.
We might want to give hash the same treatment - cache_hash doesn't make sense if hash is false. So the enum might be expanded with HASHABLE_CACHED?
Tinche
reviewed
Aug 11, 2025
| match_args: bool | ||
| str: bool | ||
| getstate_setstate: bool | ||
| on_setattr: Callable[[str, Any], Any] |
There was a problem hiding this comment.
Should these Callables be optional?
This reflects that the instance is NOT just the parameters as passed to the decorator, but how the class is actually constructed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #602
This is for now just private and the impact zone is limited. But I'm confident it can help us to simplify a bunch of code.
I'm especially rather unhappy with the weird entanglement of _ClassBuilder that doesn't really have a clear purpose (anymore?).
But let's talk in general first!