Skip to content

Changes to the pre-commit setup #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
egeakman opened this issue Jun 8, 2025 · 0 comments
Open

Changes to the pre-commit setup #24

egeakman opened this issue Jun 8, 2025 · 0 comments

Comments

@egeakman
Copy link
Member

egeakman commented Jun 8, 2025

Post-merge review (I was travelling last week): looks good :)

Only suggestions I would have made:

  • keep check-toml
  • put ruff-pre-commit first (because it might fix some things so pre-commit-hooks doesn't need to complain about them, and see the note at https://github.com/astral-sh/ruff-pre-commit about putting it before other formatters when using --fix
  • move the Ruff args out of pre-commit config and into pyproject.toml, so they are available when running Ruff outside of pre-commit

But not a big deal.

Originally posted by @hugovk in #23 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant