You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Post-merge review (I was travelling last week): looks good :)
Only suggestions I would have made:
keep check-toml
put ruff-pre-commit first (because it might fix some things so pre-commit-hooks doesn't need to complain about them, and see the note at https://github.com/astral-sh/ruff-pre-commit about putting it before other formatters when using --fix
move the Ruff args out of pre-commit config and into pyproject.toml, so they are available when running Ruff outside of pre-commit
Post-merge review (I was travelling last week): looks good :)
Only suggestions I would have made:
--fix
pyproject.toml
, so they are available when running Ruff outside of pre-commitBut not a big deal.
Originally posted by @hugovk in #23 (review)
The text was updated successfully, but these errors were encountered: