refactor(lint): remove deprecated lint()in favor of ci_lint.create()

nejch · JohnVillalovos · commit 0b17a2d24a3f · 2023-08-20T10:32:10.000-07:00
BREAKING CHANGE: The deprecated `lint()` method is no longer available.
Use `ci_lint.create()` instead.
diff --git a/gitlab/client.py b/gitlab/client.py
@@ -402,32 +402,6 @@ def version(self) -> Tuple[str, str]:
 
         return cast(str, self._server_version), cast(str, self._server_revision)
 
-    @gitlab.exceptions.on_http_error(gitlab.exceptions.GitlabVerifyError)
-    def lint(self, content: str, **kwargs: Any) -> Tuple[bool, List[str]]:
-        """Validate a gitlab CI configuration.
-
-        Args:
-            content: The .gitlab-ci.yml content
-            **kwargs: Extra options to send to the server (e.g. sudo)
-
-        Raises:
-            GitlabAuthenticationError: If authentication is not correct
-            GitlabVerifyError: If the validation could not be done
-
-        Returns:
-            (True, []) if the file is valid, (False, errors(list)) otherwise
-        """
-        utils.warn(
-            "`lint()` is deprecated and will be removed in a future version.\n"
-            "Please use `ci_lint.create()` instead.",
-            category=DeprecationWarning,
-        )
-        post_data = {"content": content}
-        data = self.http_post("/ci/lint", post_data=post_data, **kwargs)
-        if TYPE_CHECKING:
-            assert not isinstance(data, requests.Response)
-        return (data["status"] == "valid", data["errors"])
-
     @gitlab.exceptions.on_http_error(gitlab.exceptions.GitlabMarkdownError)
     def markdown(
         self, text: str, gfm: bool = False, project: Optional[str] = None, **kwargs: Any
diff --git a/tests/functional/api/test_gitlab.py b/tests/functional/api/test_gitlab.py
@@ -66,13 +66,6 @@ def test_markdown_in_project(gl, project):
     assert "foo" in html
 
 
-def test_lint(gl):
-    with pytest.deprecated_call():
-        success, errors = gl.lint("Invalid")
-    assert success is False
-    assert errors
-
-
 def test_sidekiq_queue_metrics(gl):
     out = gl.sidekiq.queue_metrics()
     assert isinstance(out, dict)
