chore: enable pylint checks

JohnVillalovos · JohnVillalovos · commit 1e8916438f7c · 2022-06-04T09:18:22.000-07:00
Enable the pylint checks:
  * unnecessary-pass
  * unspecified-encoding

Update code to resolve errors found
diff --git a/gitlab/cli.py b/gitlab/cli.py
@@ -263,7 +263,7 @@ def _parse_value(v: Any) -> Any:
         # If the user-provided value starts with @, we try to read the file
         # path provided after @ as the real value. Exit on any error.
         try:
-            with open(v[1:]) as f:
+            with open(v[1:], encoding="utf-8") as f:
                 return f.read()
         except Exception as e:
             sys.stderr.write(f"{e}\n")
diff --git a/gitlab/mixins.py b/gitlab/mixins.py
@@ -244,8 +244,6 @@ class RetrieveMixin(ListMixin, GetMixin):
     _path: Optional[str]
     gitlab: gitlab.Gitlab
 
-    pass
-
 
 class CreateMixin(_RestManagerBase):
     _computed_path: Optional[str]
@@ -429,8 +427,6 @@ class CRUDMixin(GetMixin, ListMixin, CreateMixin, UpdateMixin, DeleteMixin):
     _path: Optional[str]
     gitlab: gitlab.Gitlab
 
-    pass
-
 
 class NoUpdateMixin(GetMixin, ListMixin, CreateMixin, DeleteMixin):
     _computed_path: Optional[str]
@@ -441,8 +437,6 @@ class NoUpdateMixin(GetMixin, ListMixin, CreateMixin, DeleteMixin):
     _path: Optional[str]
     gitlab: gitlab.Gitlab
 
-    pass
-
 
 class SaveMixin(_RestObjectBase):
     """Mixin for RESTObject's that can be updated."""
diff --git a/pyproject.toml b/pyproject.toml
@@ -78,8 +78,6 @@ disable = [
     "too-many-locals",
     "too-many-statements",
     "unexpected-keyword-arg",
-    "unnecessary-pass",
-    "unspecified-encoding",
     "unsubscriptable-object",
     "unused-argument",
     "useless-import-alias",
