refactor(objects): remove deprecated constants defined in objects

nejch · JohnVillalovos · commit 3f320af347df · 2021-09-11T07:14:46.000-07:00
BREAKING CHANGE: remove deprecated constants defined in
gitlab.v4.objects, and use only gitlab.const module
diff --git a/gitlab/const.py b/gitlab/const.py
@@ -25,12 +25,11 @@
 REPORTER_ACCESS: int = 20
 DEVELOPER_ACCESS: int = 30
 MAINTAINER_ACCESS: int = 40
-MASTER_ACCESS: int = MAINTAINER_ACCESS
 OWNER_ACCESS: int = 50
 
-VISIBILITY_PRIVATE: int = 0
-VISIBILITY_INTERNAL: int = 10
-VISIBILITY_PUBLIC: int = 20
+VISIBILITY_PRIVATE: str = "private"
+VISIBILITY_INTERNAL: str = "internal"
+VISIBILITY_PUBLIC: str = "public"
 
 NOTIFICATION_LEVEL_DISABLED: str = "disabled"
 NOTIFICATION_LEVEL_PARTICIPATING: str = "participating"
diff --git a/gitlab/v4/objects/__init__.py b/gitlab/v4/objects/__init__.py
@@ -74,15 +74,4 @@
 from .variables import *
 from .wikis import *
 
-# TODO: deprecate these in favor of gitlab.const.*
-VISIBILITY_PRIVATE = "private"
-VISIBILITY_INTERNAL = "internal"
-VISIBILITY_PUBLIC = "public"
-
-ACCESS_GUEST = 10
-ACCESS_REPORTER = 20
-ACCESS_DEVELOPER = 30
-ACCESS_MASTER = 40
-ACCESS_OWNER = 50
-
 __all__ = [name for name in dir() if not name.startswith("_")]
diff --git a/tests/functional/api/test_snippets.py b/tests/functional/api/test_snippets.py
@@ -33,7 +33,7 @@ def test_project_snippets(project):
             "title": "snip1",
             "file_name": "foo.py",
             "content": "initial content",
-            "visibility": gitlab.v4.objects.VISIBILITY_PRIVATE,
+            "visibility": gitlab.VISIBILITY_PRIVATE,
         }
     )
 

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ def test_project_snippets(project):`
`33`	`33`	`"title": "snip1",`
`34`	`34`	`"file_name": "foo.py",`
`35`	`35`	`"content": "initial content",`
`36`		`- "visibility": gitlab.v4.objects.VISIBILITY_PRIVATE,`
	`36`	`+ "visibility": gitlab.VISIBILITY_PRIVATE,`
`37`	`37`	`}`
`38`	`38`	`)`
`39`	`39`