chore: enable pylint check: "attribute-defined-outside-init"

JohnVillalovos · JohnVillalovos · commit d6870a981259 · 2022-06-04T09:18:22.000-07:00
Enable the pylint check: "attribute-defined-outside-init" and fix
errors detected.
diff --git a/gitlab/client.py b/gitlab/client.py
@@ -123,6 +123,7 @@ def __init__(
 
         objects = gitlab.v4.objects
         self._objects = objects
+        self.user: Optional[objects.CurrentUser] = None
 
         self.broadcastmessages = objects.BroadcastMessageManager(self)
         """See :class:`~gitlab.v4.objects.BroadcastMessageManager`"""
diff --git a/gitlab/v4/objects/files.py b/gitlab/v4/objects/files.py
@@ -26,6 +26,8 @@
 class ProjectFile(SaveMixin, ObjectDeleteMixin, RESTObject):
     _id_attr = "file_path"
     _repr_attr = "file_path"
+    branch: str
+    commit_message: str
     file_path: str
     manager: "ProjectFileManager"
 
diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py
@@ -168,6 +168,8 @@ class ProjectMergeRequestApprovalRule(SaveMixin, ObjectDeleteMixin, RESTObject):
     _id_attr = "approval_rule_id"
     _repr_attr = "approval_rule"
     id: int
+    approval_rule_id: int
+    merge_request_iid: int
 
     @exc.on_http_error(exc.GitlabUpdateError)
     def save(self, **kwargs: Any) -> None:
diff --git a/pyproject.toml b/pyproject.toml
@@ -49,7 +49,6 @@ max-line-length = 88
 disable = [
     "arguments-differ",
     "arguments-renamed",
-    "attribute-defined-outside-init",
     "broad-except",
     "cyclic-import",
     "duplicate-code",
