chore(api): temporarily remove topic delete endpoint

nejch · JohnVillalovos · commit e3035a799a48 · 2021-12-11T10:25:08.000-08:00
It is not yet available upstream.
diff --git a/docs/gl_objects/topics.rst b/docs/gl_objects/topics.rst
@@ -39,10 +39,3 @@ Update a topic::
 
     # or
     gl.topics.update(topic_id, {"description": "My new topic"})
-
-Delete a topic::
-
-    topic.delete()
-
-    # or
-    gl.topics.delete(topic_id)
diff --git a/gitlab/v4/objects/topics.py b/gitlab/v4/objects/topics.py
@@ -2,19 +2,19 @@
 
 from gitlab import types
 from gitlab.base import RequiredOptional, RESTManager, RESTObject
-from gitlab.mixins import CRUDMixin, ObjectDeleteMixin, SaveMixin
+from gitlab.mixins import CreateMixin, RetrieveMixin, SaveMixin, UpdateMixin
 
 __all__ = [
     "Topic",
     "TopicManager",
 ]
 
 
-class Topic(SaveMixin, ObjectDeleteMixin, RESTObject):
+class Topic(SaveMixin, RESTObject):
     pass
 
 
-class TopicManager(CRUDMixin, RESTManager):
+class TopicManager(CreateMixin, RetrieveMixin, UpdateMixin, RESTManager):
     _path = "/topics"
     _obj_cls = Topic
     _create_attrs = RequiredOptional(
diff --git a/tests/functional/api/test_topics.py b/tests/functional/api/test_topics.py
@@ -16,6 +16,3 @@ def test_topics(gl):
 
     updated_topic = gl.topics.get(topic.id)
     assert updated_topic.description == topic.description
-
-    topic.delete()
-    assert not gl.topics.list()
diff --git a/tests/functional/conftest.py b/tests/functional/conftest.py
@@ -24,8 +24,6 @@ def reset_gitlab(gl):
         for deploy_token in group.deploytokens.list():
             deploy_token.delete()
         group.delete()
-    for topic in gl.topics.list():
-        topic.delete()
     for variable in gl.variables.list():
         variable.delete()
     for user in gl.users.list():
diff --git a/tests/unit/objects/test_topics.py b/tests/unit/objects/test_topics.py
@@ -75,19 +75,6 @@ def resp_update_topic():
         yield rsps
 
 
-@pytest.fixture
-def resp_delete_topic(no_content):
-    with responses.RequestsMock() as rsps:
-        rsps.add(
-            method=responses.DELETE,
-            url=topic_url,
-            json=no_content,
-            content_type="application/json",
-            status=204,
-        )
-        yield rsps
-
-
 def test_list_topics(gl, resp_list_topics):
     topics = gl.topics.list()
     assert isinstance(topics, list)
@@ -112,8 +99,3 @@ def test_update_topic(gl, resp_update_topic):
     topic.name = new_name
     topic.save()
     assert topic.name == new_name
-
-
-def test_delete_topic(gl, resp_delete_topic):
-    topic = gl.topics.get(1, lazy=True)
-    topic.delete()
