Merge pull request #420 from python-semver/classvar

tomschr · web-flow · commit fda28738fc0d · 2023-07-23T10:04:20.000+02:00
Introduce ClassVar type
diff --git a/changelog.d/pr420.trivial.rst b/changelog.d/pr420.trivial.rst
@@ -0,0 +1,2 @@
+Introduce :py:class:`~typing.ClassVar` for some :class:`~semver.version.Version`
+class variables, mainly :data:`~semver.version.Version.NAMES` and some private.
diff --git a/pyproject.toml b/pyproject.toml
@@ -14,7 +14,6 @@ requires = [
 build-backend = "setuptools.build_meta"
 
 
-
 [tool.black]
 line-length = 88
 target-version = ['py37', 'py38', 'py39', 'py310', 'py311']
diff --git a/src/semver/version.py b/src/semver/version.py
@@ -4,9 +4,11 @@
 from functools import wraps
 from typing import (
     Any,
+    ClassVar,
     Dict,
     Iterable,
     Optional,
+    Pattern,
     SupportsInt,
     Tuple,
     Union,
@@ -72,12 +74,14 @@ class Version:
     __slots__ = ("_major", "_minor", "_patch", "_prerelease", "_build")
 
     #: The names of the different parts of a version
-    NAMES = tuple([item[1:] for item in __slots__])
+    NAMES: ClassVar[Tuple[str, ...]] = tuple([item[1:] for item in __slots__])
 
     #: Regex for number in a prerelease
-    _LAST_NUMBER = re.compile(r"(?:[^\d]*(\d+)[^\d]*)+")
+    _LAST_NUMBER: ClassVar[Pattern] = re.compile(r"(?:[^\d]*(\d+)[^\d]*)+")
     #: Regex template for a semver version
-    _REGEX_TEMPLATE = r"""
+    _REGEX_TEMPLATE: ClassVar[
+        str
+    ] = r"""
             ^
             (?P<major>0|[1-9]\d*)
             (?:
@@ -99,12 +103,12 @@ class Version:
             $
         """
     #: Regex for a semver version
-    _REGEX = re.compile(
+    _REGEX: ClassVar[Pattern] = re.compile(
         _REGEX_TEMPLATE.format(opt_patch="", opt_minor=""),
         re.VERBOSE,
     )
     #: Regex for a semver version that might be shorter
-    _REGEX_OPTIONAL_MINOR_AND_PATCH = re.compile(
+    _REGEX_OPTIONAL_MINOR_AND_PATCH: ClassVar[Pattern] = re.compile(
         _REGEX_TEMPLATE.format(opt_patch="?", opt_minor="?"),
         re.VERBOSE,
     )

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Introduce :py:class:`~typing.ClassVar` for some :class:`~semver.version.Version`
	`2`	+class variables, mainly :data:`~semver.version.Version.NAMES` and some private.