Skip to content

441 update pydantic section of docs #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jbkroner
Copy link

@jbkroner jbkroner commented Jul 26, 2024

Closes #441

Small docs update, includes updated guidance on using Pydantic with python-semver.

Holding this in a draft state until the _VersionPydanticAnnotation is included in the next pydantic-extra-types release, probably version 2.10.0.

Any and all feedback appreciated, cheers.

@jbkroner jbkroner changed the title 441 update docs 441 update pydantic section of docs Jul 26, 2024
@tomschr
Copy link
Member

tomschr commented Jul 28, 2024

Hi @jbkroner, are you ready with the PR or do you want to amend it? Just asking as the "Draft" label here is still in place and I didn't want to merge something unfinished. 😉

Thanks, looks good!

Copy link
Member

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbkroner Just a small, minor suggestion. Apart from that, it looks good! 👍

@jbkroner
Copy link
Author

jbkroner commented Aug 1, 2024

Hi @jbkroner, are you ready with the PR or do you want to amend it? Just asking as the "Draft" label here is still in place and I didn't want to merge something unfinished. 😉

Thanks, looks good!

@tomschr I applied your feedback - keeping this in a draft state until the changes referenced in this update are included in an official pydantic-extra-types release. Looks like they typically release every month or so.

jbkroner and others added 3 commits January 8, 2025 09:58
Co-authored-by: Tom Schraitle <tomschr@users.noreply.github.com>
Co-authored-by: Tom Schraitle <tomschr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Pydantic + semver documentation
2 participants