Fix bug: non-maximum suppression for hough circle

yanlend · web-flow · commit 332588fceef6 · 2017-09-27T11:47:30.000+02:00
The non-maximum suppression in the Hough accumulator incorrectly ignores maxima that extend over more than one cell, i.e. two neighboring cells both have the same accumulator value. This maximum is dropped completely instead of picking at least one of the entries. This frequently results in obvious circles being missed. The behavior is now changed to be the same as for hough_lines. See also opencv#4440
diff --git a/modules/imgproc/src/hough.cpp b/modules/imgproc/src/hough.cpp
@@ -1112,8 +1112,8 @@ icvHoughCirclesGradient( CvMat* img, float dp, float min_dist,
         {
             int base = y*(acols+2) + x;
             if( adata[base] > acc_threshold &&
-                adata[base] > adata[base-1] && adata[base] > adata[base+1] &&
-                adata[base] > adata[base-acols-2] && adata[base] > adata[base+acols+2] )
+                adata[base] > adata[base-1] && adata[base] >= adata[base+1] &&
+                adata[base] > adata[base-acols-2] && adata[base] >= adata[base+acols+2] )
                 cvSeqPush(centers, &base);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -1112,8 +1112,8 @@ icvHoughCirclesGradient( CvMat* img, float dp, float min_dist,`
`1112`	`1112`	`{`
`1113`	`1113`	`int base = y*(acols+2) + x;`
`1114`	`1114`	`if( adata[base] > acc_threshold &&`
`1115`		`- adata[base] > adata[base-1] && adata[base] > adata[base+1] &&`
`1116`		`- adata[base] > adata[base-acols-2] && adata[base] > adata[base+acols+2] )`
	`1115`	`+ adata[base] > adata[base-1] && adata[base] >= adata[base+1] &&`
	`1116`	`+ adata[base] > adata[base-acols-2] && adata[base] >= adata[base+acols+2] )`
`1117`	`1117`	`cvSeqPush(centers, &base);`
`1118`	`1118`	`}`
`1119`	`1119`	`}`