Add some useful input assertions to PSNR function

saskatchewancatch · web-flow · commit 6da62f56facc · 2017-09-15T23:36:58.000-06:00
Input arrays must be depth CV_8U and of identical size.
diff --git a/modules/core/src/stat.cpp b/modules/core/src/stat.cpp
@@ -4150,7 +4150,10 @@ double cv::PSNR(InputArray _src1, InputArray _src2)
 {
     CV_INSTRUMENT_REGION()
 
-    CV_Assert( _src1.depth() == CV_8U );
+    //Input arrays must have depth CV_8U and be of identical size
+    CV_Assert( _src1.depth() == CV_8U && _src2.depth() == CV_8U );
+    CV_Assert( _src1.rows() == _src2.rows() && _src1.cols() == _src2.cols() && _src1.dims() == _src2.dims() );
+
     double diff = std::sqrt(norm(_src1, _src2, NORM_L2SQR)/(_src1.total()*_src1.channels()));
     return 20*log10(255./(diff+DBL_EPSILON));
 }

Original file line number	Diff line number	Diff line change
`@@ -4150,7 +4150,10 @@ double cv::PSNR(InputArray _src1, InputArray _src2)`
`4150`	`4150`	`{`
`4151`	`4151`	`CV_INSTRUMENT_REGION()`
`4152`	`4152`
`4153`		`- CV_Assert( _src1.depth() == CV_8U );`
	`4153`	`+ //Input arrays must have depth CV_8U and be of identical size`
	`4154`	`+ CV_Assert( _src1.depth() == CV_8U && _src2.depth() == CV_8U );`
	`4155`	`+ CV_Assert( _src1.rows() == _src2.rows() && _src1.cols() == _src2.cols() && _src1.dims() == _src2.dims() );`
	`4156`	`+`
`4154`	`4157`	`double diff = std::sqrt(norm(_src1, _src2, NORM_L2SQR)/(_src1.total()*_src1.channels()));`
`4155`	`4158`	`return 20*log10(255./(diff+DBL_EPSILON));`
`4156`	`4159`	`}`