fixed optional args processing in SVD::compute()

savuor · savuor · commit cb52d249fed9 · 2016-09-06T14:09:44.000+03:00
diff --git a/modules/core/src/lapack.cpp b/modules/core/src/lapack.cpp
@@ -1560,18 +1560,18 @@ static void _SVDcompute( InputArray _aarr, OutputArray _w,
         JacobiSVD(temp_a.ptr<double>(), temp_u.step, temp_w.ptr<double>(),
               temp_v.ptr<double>(), temp_v.step, m, n, compute_uv ? urows : 0);
     }
-    temp_w.copyTo(_w);
+    if(_w.needed()) temp_w.copyTo(_w);
     if( compute_uv )
     {
         if( !at )
         {
-            transpose(temp_u, _u);
-            temp_v.copyTo(_vt);
+            if(_u.needed()) transpose(temp_u, _u);
+            if(_vt.needed()) temp_v.copyTo(_vt);
         }
         else
         {
-            transpose(temp_v, _u);
-            temp_u.copyTo(_vt);
+            if(_u.needed()) transpose(temp_v, _u);
+            if(_vt.needed()) temp_u.copyTo(_vt);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1560,18 +1560,18 @@ static void _SVDcompute( InputArray _aarr, OutputArray _w,`
`1560`	`1560`	`JacobiSVD(temp_a.ptr<double>(), temp_u.step, temp_w.ptr<double>(),`
`1561`	`1561`	`temp_v.ptr<double>(), temp_v.step, m, n, compute_uv ? urows : 0);`
`1562`	`1562`	`}`
`1563`		`- temp_w.copyTo(_w);`
	`1563`	`+ if(_w.needed()) temp_w.copyTo(_w);`
`1564`	`1564`	`if( compute_uv )`
`1565`	`1565`	`{`
`1566`	`1566`	`if( !at )`
`1567`	`1567`	`{`
`1568`		`- transpose(temp_u, _u);`
`1569`		`- temp_v.copyTo(_vt);`
	`1568`	`+ if(_u.needed()) transpose(temp_u, _u);`
	`1569`	`+ if(_vt.needed()) temp_v.copyTo(_vt);`
`1570`	`1570`	`}`
`1571`	`1571`	`else`
`1572`	`1572`	`{`
`1573`		`- transpose(temp_v, _u);`
`1574`		`- temp_u.copyTo(_vt);`
	`1573`	`+ if(_u.needed()) transpose(temp_v, _u);`
	`1574`	`+ if(_vt.needed()) temp_u.copyTo(_vt);`
`1575`	`1575`	`}`
`1576`	`1576`	`}`
`1577`	`1577`	`}`