Add a test when url isn't valid (repository name is null)

Vlatombe · Vlatombe · commit 330cdbe3499e · 2016-07-21T18:26:04.000+02:00
diff --git a/src/main/java/org/jenkinsci/plugins/github/status/sources/ManuallyEnteredRepositorySource.java b/src/main/java/org/jenkinsci/plugins/github/status/sources/ManuallyEnteredRepositorySource.java
@@ -1,6 +1,7 @@
 package org.jenkinsci.plugins.github.status.sources;
 
 import com.cloudbees.jenkins.GitHubRepositoryName;
+import com.google.common.annotations.VisibleForTesting;
 import hudson.Extension;
 import hudson.model.Descriptor;
 import hudson.model.Run;
@@ -28,13 +29,18 @@ public String getUrl() {
         return url;
     }
 
+    @VisibleForTesting
+    GitHubRepositoryName createName(String url) {
+        return GitHubRepositoryName.create(url);
+    }
+
     @Override
     public List<GHRepository> repos(@Nonnull Run<?, ?> run, @Nonnull final TaskListener listener) {
         List<String> urls = Collections.singletonList(url);
         return from(urls).transformAndConcat(new NullSafeFunction<String, Iterable<GHRepository>>() {
             @Override
             protected Iterable<GHRepository> applyNullSafe(@Nonnull String url) {
-                GitHubRepositoryName name = GitHubRepositoryName.create(url);
+                GitHubRepositoryName name = createName(url);
                 if (name != null) {
                     return name.resolve();
                 } else {
diff --git a/src/test/java/org/jenkinsci/plugins/github/status/sources/ManuallyEnteredRepositorySourceTest.java b/src/test/java/org/jenkinsci/plugins/github/status/sources/ManuallyEnteredRepositorySourceTest.java
@@ -0,0 +1,45 @@
+package org.jenkinsci.plugins.github.status.sources;
+
+import hudson.model.Run;
+import hudson.model.TaskListener;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.kohsuke.github.GHRepository;
+import org.mockito.Answers;
+import org.mockito.Matchers;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import java.io.PrintStream;
+import java.util.List;
+
+import static com.jayway.restassured.RestAssured.when;
+import static org.hamcrest.collection.IsCollectionWithSize.hasSize;
+import static org.junit.Assert.assertThat;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.verify;
+
+@RunWith(MockitoJUnitRunner.class)
+public class ManuallyEnteredRepositorySourceTest {
+    @Mock(answer = Answers.RETURNS_MOCKS)
+    private Run run;
+
+    @Mock(answer = Answers.RETURNS_MOCKS)
+    private TaskListener listener;
+
+    @Mock(answer = Answers.RETURNS_MOCKS)
+    private PrintStream logger;
+
+    @Test
+    public void nullName() {
+        ManuallyEnteredRepositorySource instance = Mockito.spy(new ManuallyEnteredRepositorySource("https://github.com/jenkinsci/jenkins"));
+        doReturn(null).when(instance).createName(Matchers.anyString());
+        doReturn(logger).when(listener).getLogger();
+        List<GHRepository> repos = instance.repos(run, listener);
+        assertThat("size", repos, hasSize(0));
+        verify(listener).getLogger();
+        verify(logger).printf(eq("Unable to match %s with a GitHub repository.%n"), eq("https://github.com/jenkinsci/jenkins"));
+    }
+}
