feat: Add a setting for "vue-devtools Detected Vue" console log, closes vuejs#685 (vuejs#811)

emanuelmutschlechner · Guillaume Chau · Akryum · commit 3c00b4546dea · 2019-03-20T15:26:23.000+01:00
* feat: Add a setting for "vue-devtools Detected Vue" console log, closes vuejs#685 * Fix check for cold storage * fix: use SharedData * refactor: invert setting Co-authored-by: Guillaume Chau <alphadelta.fg@gmail.com>
diff --git a/src/backend/index.js b/src/backend/index.js
@@ -153,12 +153,14 @@ function connect (Vue) {
 
   bridge.log('backend ready.')
   bridge.send('ready', Vue.version)
-  console.log(
-    `%c vue-devtools %c Detected Vue v${Vue.version} %c`,
-    'background:#35495e ; padding: 1px; border-radius: 3px 0 0 3px;  color: #fff',
-    'background:#41b883 ; padding: 1px; border-radius: 0 3px 3px 0;  color: #fff',
-    'background:transparent'
-  )
+  if (SharedData.logDetected) {
+    console.log(
+      `%c vue-devtools %c Detected Vue v${Vue.version} %c`,
+      'background:#35495e ; padding: 1px; border-radius: 3px 0 0 3px;  color: #fff',
+      'background:#41b883 ; padding: 1px; border-radius: 0 3px 3px 0;  color: #fff',
+      'background:transparent'
+    )
+  }
 
   setTimeout(() => {
     scan()
diff --git a/src/devtools/views/settings/GlobalPreferences.vue b/src/devtools/views/settings/GlobalPreferences.vue
@@ -67,6 +67,15 @@
         Enable <span class="dim">(may print warnings)</span>
       </VueSwitch>
     </VueFormField>
+
+    <VueFormField title="Detected Vue message">
+      <VueSwitch
+        :value="$shared.logDetected"
+        @input="$shared.logDetected = $event"
+      >
+        Display in browser console
+      </VueSwitch>
+    </VueFormField>
   </div>
 </template>
 
diff --git a/src/shared-data.js b/src/shared-data.js
@@ -11,15 +11,17 @@ const internalSharedData = {
   cacheVuexSnapshotsLimit: 10,
   snapshotLoading: null,
   recordPerf: false,
-  editableProps: false
+  editableProps: false,
+  logDetected: true
 }
 
 const persisted = [
   'classifyComponents',
   'theme',
   'displayDensity',
   'recordVuex',
-  'editableProps'
+  'editableProps',
+  'logDetected'
 ]
 
 // ---- INTERNALS ---- //
