[sns] handled comments

Igor Paramonov · Igor Paramonov · commit 5f0bd439c342 · 2021-03-18T13:40:24.000+02:00
diff --git a/pkg/sns/SnsConnectionFactory.php b/pkg/sns/SnsConnectionFactory.php
@@ -75,7 +75,7 @@ public function __construct($config = 'sns:')
      */
     public function createContext(): Context
     {
-        return new SnsContext($this->establishConnection(), $this->config, $this->config['topic_arns']);
+        return new SnsContext($this->establishConnection(), $this->config);
     }
 
     private function establishConnection(): SnsClient
@@ -148,7 +148,7 @@ private function extractTopicArns(?string $topicArns): array
 
         return array_column(
             array_map(function ($topic) {
-                list ($name, $arn) = explode('|', $topic);
+                list($name, $arn) = explode('|', $topic);
 
                 return [
                     'name' => $name,
diff --git a/pkg/sns/SnsContext.php b/pkg/sns/SnsContext.php
@@ -31,11 +31,11 @@ class SnsContext implements Context
 
     private $topicArns;
 
-    public function __construct(SnsClient $client, array $config, array $topicArns = [])
+    public function __construct(SnsClient $client, array $config)
     {
         $this->client = $client;
         $this->config = $config;
-        $this->topicArns = $topicArns;
+        $this->topicArns = $config['topic_arns'];
     }
 
     /**
diff --git a/pkg/sns/Tests/Spec/SnsContextTest.php b/pkg/sns/Tests/Spec/SnsContextTest.php
@@ -20,6 +20,6 @@ protected function createContext()
     {
         $client = $this->createMock(SnsClient::class);
 
-        return new SnsContext($client, []);
+        return new SnsContext($client, ['topic_arns' => []]);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public function __construct($config = 'sns:')`
`75`	`75`	`*/`
`76`	`76`	`public function createContext(): Context`
`77`	`77`	`{`
`78`		`- return new SnsContext($this->establishConnection(), $this->config, $this->config['topic_arns']);`
	`78`	`+ return new SnsContext($this->establishConnection(), $this->config);`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`private function establishConnection(): SnsClient`
`@@ -148,7 +148,7 @@ private function extractTopicArns(?string $topicArns): array`
`148`	`148`
`149`	`149`	`return array_column(`
`150`	`150`	`array_map(function ($topic) {`
`151`		`- list ($name, $arn) = explode('\|', $topic);`
	`151`	`+ list($name, $arn) = explode('\|', $topic);`
`152`	`152`
`153`	`153`	`return [`
`154`	`154`	`'name' => $name,`
Original file line number	Diff line number	Diff line change
`@@ -31,11 +31,11 @@ class SnsContext implements Context`
`31`	`31`
`32`	`32`	`private $topicArns;`
`33`	`33`
`34`		`- public function __construct(SnsClient $client, array $config, array $topicArns = [])`
	`34`	`+ public function __construct(SnsClient $client, array $config)`
`35`	`35`	`{`
`36`	`36`	`$this->client = $client;`
`37`	`37`	`$this->config = $config;`
`38`		`- $this->topicArns = $topicArns;`
	`38`	`+ $this->topicArns = $config['topic_arns'];`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,6 @@ protected function createContext()`
`20`	`20`	`{`
`21`	`21`	`$client = $this->createMock(SnsClient::class);`
`22`	`22`
`23`		`- return new SnsContext($client, []);`
	`23`	`+ return new SnsContext($client, ['topic_arns' => []]);`
`24`	`24`	`}`
`25`	`25`	`}`