Check stream context is null (swoole#4016)

ZhiyangLeeCN · web-flow · commit 1ee4182a37ef · 2021-01-22T09:54:57.000+08:00
diff --git a/ext-src/swoole_runtime.cc b/ext-src/swoole_runtime.cc
@@ -761,9 +761,12 @@ static int socket_enable_crypto(php_stream *stream, Socket *sock, php_stream_xpo
         return sock->ssl_shutdown() ? 0 : -1;
     }
 
-    zval *val = php_stream_context_get_option(PHP_STREAM_CONTEXT(stream), "ssl", "capture_peer_cert");
-    if (val && zend_is_true(val)) {
-        return php_openssl_capture_peer_certs(stream, sock) ? 0 : -1;
+    php_stream_context *context = PHP_STREAM_CONTEXT(stream);
+    if (context) {
+        zval *val = php_stream_context_get_option(context, "ssl", "capture_peer_cert");
+        if (val && zend_is_true(val)) {
+            return php_openssl_capture_peer_certs(stream, sock) ? 0 : -1;
+        }
     }
 
     return 0;
diff --git a/tests/swoole_runtime/stream_context_pass_null.phpt b/tests/swoole_runtime/stream_context_pass_null.phpt
@@ -0,0 +1,19 @@
+--TEST--
+swoole_runtime: stream context pass null
+--SKIPIF--
+<?php require __DIR__ . '/../include/skipif.inc'; ?>
+--FILE--
+<?php
+require __DIR__ . '/../include/bootstrap.php';
+
+swoole\runtime::enableCoroutine();
+go(function() {
+   //This function internal send null stream context parameter to `php_stream_open_wrapper_ex`
+   $md5 = md5_file('https://www.baidu.com');
+   var_dump(!empty($md5));
+});
+swoole_event_wait();
+
+?>
+--EXPECT--
+bool(true)

Original file line number	Diff line number	Diff line change
`@@ -761,9 +761,12 @@ static int socket_enable_crypto(php_stream stream, Socket sock, php_stream_xpo`
`761`	`761`	`return sock->ssl_shutdown() ? 0 : -1;`
`762`	`762`	`}`
`763`	`763`
`764`		`- zval *val = php_stream_context_get_option(PHP_STREAM_CONTEXT(stream), "ssl", "capture_peer_cert");`
`765`		`- if (val && zend_is_true(val)) {`
`766`		`- return php_openssl_capture_peer_certs(stream, sock) ? 0 : -1;`
	`764`	`+ php_stream_context *context = PHP_STREAM_CONTEXT(stream);`
	`765`	`+ if (context) {`
	`766`	`+ zval *val = php_stream_context_get_option(context, "ssl", "capture_peer_cert");`
	`767`	`+ if (val && zend_is_true(val)) {`
	`768`	`+ return php_openssl_capture_peer_certs(stream, sock) ? 0 : -1;`
	`769`	`+ }`
`767`	`770`	`}`
`768`	`771`
`769`	`772`	`return 0;`