Remove .travis.yml and update codecov (swoole#4191)

sy-records · web-flow · commit c265fba22d9c · 2021-05-10T11:22:22.000+08:00
diff --git a/.github/workflows/lib.yml b/.github/workflows/lib.yml
@@ -3,7 +3,7 @@ name: lib-swoole
 on: [push, pull_request]
 
 env:
-  CODECOV_TOKEN: "50513381-198e-43d3-a8b1-e36b95038927" # from: https://codecov.io/gh/swoole/swoole-src
+  CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
 jobs:
   build:
@@ -41,6 +41,11 @@ jobs:
       run: sudo apt-get install lcov &&
           sudo lcov --directory . --capture --output-file coverage.info &&
           sudo lcov --remove coverage.info "${{runner.workspace}}/swoole-src/include/*" '/usr/*' --output-file coverage.info &&
-          sudo lcov --list coverage.info &&
-          sudo curl -s https://codecov.io/bash -o codecov.sh &&
-          sudo chmod +x codecov.sh && sudo ./codecov.sh -f coverage.info -t ${CODECOV_TOKEN}
+          sudo lcov --list coverage.info
+
+    - name: Upload coverage to Codecov
+      uses: codecov/codecov-action@v1
+      with:
+        token: ${{ secrets.CODECOV_TOKEN }}
+        files: ./coverage.info
+        fail_ci_if_error: true
diff --git a/.travis.yml b/.travis.yml
diff --git a/ext-src/php_swoole_library.h b/ext-src/php_swoole_library.h
@@ -2,7 +2,7 @@
  * Generated by build-library.php, Please DO NOT modify!
  */
 
-/* $Id: c1d47051d7a949c0a76ca595f6d523faa2ecc3b9 */
+/* $Id: b2d3486c3bca310c730de8575e71b27d2d0ee30d */
 
 static const char* swoole_library_source_constants =
     "\n"
@@ -2803,9 +2803,14 @@ static const char* swoole_library_source_core_database_pdo_proxy =
     "                    || $n === 0\n"
     "                    || $this->__object->inTransaction()\n"
     "                ) {\n"
-    "                    $exception = new PDOException($errorInfo[2], $errorInfo[1]);\n"
-    "                    $exception->errorInfo = $errorInfo;\n"
-    "                    throw $exception;\n"
+    "                    /* '00000' means “no error.”, as specified by ANSI SQL and ODBC. */\n"
+    "                    if (!empty($errorInfo) && $errorInfo[0] !== '00000') {\n"
+    "                        $exception = new PDOException($errorInfo[2], $errorInfo[1]);\n"
+    "                        $exception->errorInfo = $errorInfo;\n"
+    "                        throw $exception;\n"
+    "                    }\n"
+    "                    /* no error info, just return false */\n"
+    "                    break;\n"
     "                }\n"
     "                $this->reconnect();\n"
     "                continue;\n"
@@ -2917,12 +2922,14 @@ static const char* swoole_library_source_core_database_pdo_statement_proxy =
     "                ) {\n"
     "                    $errorInfo = $this->__object->errorInfo();\n"
     "\n"
-    "                    // '00000' means “no error.”, as specified by ANSI SQL and ODBC.\n"
-    "                    if ($errorInfo[0] !== '00000') {\n"
+    "                    /* '00000' means “no error.”, as specified by ANSI SQL and ODBC. */\n"
+    "                    if (!empty($errorInfo) && $errorInfo[0] !== '00000') {\n"
     "                        $exception = new PDOException($errorInfo[2], $errorInfo[1]);\n"
     "                        $exception->errorInfo = $errorInfo;\n"
     "                        throw $exception;\n"
     "                    }\n"
+    "                    /* no error info, just return false */\n"
+    "                    break;\n"
     "                }\n"
     "                if ($this->parent->getRound() === $this->parentRound) {\n"
     "                    /* if not equal, parent has reconnected */\n"
