Fixed memory leak in WebSocket transport.

mlinnell · mlinnell · commit d2ecaff462ed · 2011-02-23T18:55:24.000Z
The WebSocket.buffer would continue to grow, unabated, for each new message.
This buffer is now only utilized to process the nonce, and is set to empty (and no longer filled) once nonce has been received.
Parser instance appears to handle all message buffering, instead of WebSocket entity.
diff --git a/lib/socket.io/transports/websocket.js b/lib/socket.io/transports/websocket.js
@@ -99,18 +99,15 @@ WebSocket.prototype._onConnect = function(req, socket){
   this.buffer = "";
   
   this.connection.addListener('data', function(data){
-    self.buffer += data;
     if (self.waitingForNonce) {
+    		self.buffer += data;
+
   		if (self.buffer.length < 8) { return; }
   		// Restore the connection to utf8 encoding after receiving the nonce
   		self.connection.setEncoding('utf8');
   		self.waitingForNonce = false;
   		// Stuff the nonce into the location where it's expected to be
   		self.upgradeHead = self.buffer.substr(0,8);
-  		self.buffer = self.buffer.substr(8);
-  		if (self.buffer.length > 0) {
-  		  self.parser.add(self.buffer);
-  		}
   		if (self._proveReception(self._headers)) { self._payload(); }
   		return;
   	}
