Don't let errors in an application's message handling code get silently swallowed by any of the transports

marcuswestin · marcuswestin · commit f534a260b373 · 2011-02-14T19:56:20.000-05:00
diff --git a/lib/socket.io/transports/htmlfile.js b/lib/socket.io/transports/htmlfile.js
@@ -32,7 +32,9 @@ HTMLFile.prototype._onConnect = function(req, res){
         try {
           var msg = qs.parse(body);
           self._onMessage(msg.data);
-        } catch(e){}
+        } catch(e){
+          listener.options.log('htmlfile message handler error - ' + e.stack);
+        }
         res.writeHead(200, {'Content-Type': 'text/plain'});
         res.write('ok');
         res.end();
diff --git a/lib/socket.io/transports/xhr-multipart.js b/lib/socket.io/transports/xhr-multipart.js
@@ -46,7 +46,9 @@ Multipart.prototype._onConnect = function(req, res){
         try {
           var msg = qs.parse(body);
           self._onMessage(msg.data);
-        } catch(e){}
+        } catch(e){
+          listener.options.log('xhr-multipart message handler error - ' + e.stack);
+        }
         res.writeHead(200, headers);
         res.write('ok');
         res.end();
diff --git a/lib/socket.io/transports/xhr-polling.js b/lib/socket.io/transports/xhr-polling.js
@@ -48,7 +48,9 @@ Polling.prototype._onConnect = function(req, res){
           // optimization: just strip first 5 characters here?
           var msg = qs.parse(body);
           self._onMessage(msg.data);
-        } catch(e){}
+        } catch(e){
+          listener.options.log('xhr-polling message handler error - ' + e.stack);
+        }
         res.writeHead(200, headers);
         res.write('ok');
         res.end();
