Addendum to fixing bug #26173244:

gkodinov · dahlerlend · commit 7c486b87cabb · 2017-08-22T09:30:13.000+02:00
Fix for a failing test udf_skip_grants
Rased the flag for UDF initialiation at the right time to indicate
if SQL UDF definition/removal is allowed.
The flag is no longer used to indicate if the global structures
are allocated or not (as they are always allocated).
diff --git a/sql/sql_udf.cc b/sql/sql_udf.cc
@@ -105,7 +105,7 @@
   \ref mem and \ref THR_LOCK_udf are always initialized, even in
   --skip-grant-tables mode.
 */
-static bool initialized = 0;
+static bool initialized= 0;
 static MEM_ROOT mem;
 static collation_unordered_map<std::string, udf_func*> *udf_hash;
 static mysql_rwlock_t THR_LOCK_udf;
@@ -225,11 +225,11 @@ void udf_read_functions_table()
 
   if (initialized)
   {
-    DBUG_ASSERT("wrong init order: trying to read the UDFs without initializaton");
+    DBUG_ASSERT("wrong init order: reading UDFs from the table twice");
     DBUG_VOID_RETURN;
   }
 
-  initialized = 1;
+  initialized= 1;
 
   THD *new_thd = new(std::nothrow) THD;
   if (new_thd == nullptr)
