Bug #26724559 NDB : VALGRIND : NDB_MODIFIERS LEAKS MEMORY

frazerclement · frazerclement · commit d87f7e6691db · 2017-08-31T17:53:51.000+01:00
Fix error path leak.

Refactoring to follow
diff --git a/sql/ha_ndbcluster.cc b/sql/ha_ndbcluster.cc
@@ -9525,6 +9525,10 @@ NDB_Modifiers::parse(THD *thd,
       }
       my_error(ER_ILLEGAL_HA_CREATE_OPTION, MYF(0), ndbcluster_hton_name,
                "Syntax error in COMMENT modifier");
+      if (source != _source)
+      {
+        delete [] source;
+      }
       return -1;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -9525,6 +9525,10 @@ NDB_Modifiers::parse(THD *thd,`
`9525`	`9525`	`}`
`9526`	`9526`	`my_error(ER_ILLEGAL_HA_CREATE_OPTION, MYF(0), ndbcluster_hton_name,`
`9527`	`9527`	`"Syntax error in COMMENT modifier");`
	`9528`	`+ if (source != _source)`
	`9529`	`+ {`
	`9530`	`+ delete [] source;`
	`9531`	`+ }`
`9528`	`9532`	`return -1;`
`9529`	`9533`	`}`
`9530`	`9534`