Enhance user keyword argument conversion errors

pekkaklarck · pekkaklarck · commit e38c868565ac · 2025-05-30T12:26:35.000+03:00
Error messages enhanced in these cases:
- Embedded argument value is invalid.
- Argument default value is invalid.
diff --git a/atest/robot/variables/variable_types.robot b/atest/robot/variables/variable_types.robot
@@ -141,7 +141,7 @@ User keyword
 User keyword: Default value
     Check Test Case    ${TESTNAME}
 
-User keyword: Wrong default value
+User keyword: Invalid default value
     Check Test Case    ${TESTNAME} 1
     Check Test Case    ${TESTNAME} 2
 
@@ -151,15 +151,15 @@ User keyword: Invalid value
 User keyword: Invalid type
     Check Test Case    ${TESTNAME}
     Error In File
-    ...    0    variables/variable_types.robot    480
+    ...    0    variables/variable_types.robot    481
     ...    Creating keyword 'Bad type' failed:
     ...    Invalid argument specification: Invalid argument '\${arg: bad}':
     ...    Unrecognized type 'bad'.
 
 User keyword: Invalid assignment with kwargs k_type=v_type declaration
     Check Test Case    ${TESTNAME}
     Error In File
-    ...    1    variables/variable_types.robot    484
+    ...    1    variables/variable_types.robot    485
     ...    Creating keyword 'Kwargs does not support key=value type syntax' failed:
     ...    Invalid argument specification: Invalid argument '\&{kwargs: int=float}':
     ...    Unrecognized type 'int=float'.
@@ -182,7 +182,7 @@ Embedded arguments: Invalid value from variable
 Embedded arguments: Invalid type
     Check Test Case    ${TESTNAME}
     Error In File
-    ...    2    variables/variable_types.robot    504
+    ...    2    variables/variable_types.robot    505
     ...    Creating keyword 'Embedded invalid type \${x: invalid}' failed:
     ...    Invalid embedded argument '\${x: invalid}':
     ...    Unrecognized type 'invalid'.
diff --git a/atest/testdata/variables/variable_types.robot b/atest/testdata/variables/variable_types.robot
@@ -235,15 +235,16 @@ User keyword: Default value
     Default as string
     Default as string    ${42}
 
-User keyword: Wrong default value 1
+User keyword: Invalid default value 1
     [Documentation]    FAIL
-    ...    ValueError: Argument default value 'arg' got value 'wrong' that cannot be converted to integer.
-    Wrong default
+    ...    ValueError: Default value for argument 'arg' got value 'invalid' that cannot be converted to integer.
+    Invalid default
 
-User keyword: Wrong default value 2
+User keyword: Invalid default value 2
     [Documentation]    FAIL
-    ...    ValueError: Argument 'arg' got value 'yyy' that cannot be converted to integer.
-    Wrong default    yyy
+    ...    ValueError: Argument 'arg' got value 'bad' that cannot be converted to integer.
+    Invalid default    42
+    Invalid default    bad
 
 User keyword: Invalid value
     [Documentation]    FAIL
@@ -280,11 +281,11 @@ Embedded arguments: With variables
     Embedded ${x} and ${y}
 
 Embedded arguments: Invalid value
-    [Documentation]    FAIL    ValueError: Argument 'kala' cannot be converted to integer.
+    [Documentation]    FAIL    ValueError: Argument 'y' got value 'kala' that cannot be converted to integer.
     Embedded 1 and kala
 
 Embedded arguments: Invalid value from variable
-    [Documentation]    FAIL    ValueError: Argument '[2, 3]' (list) cannot be converted to integer.
+    [Documentation]    FAIL    ValueError: Argument 'y' got value '[2, 3]' (list) that cannot be converted to integer.
     Embedded 1 and ${{[2, 3]}}
 
 Embedded arguments: Invalid type
@@ -472,9 +473,9 @@ Default as string
     Should be equal    ${arg}    42    type=str
     RETURN    ${arg}
 
-Wrong default
-    [Arguments]    ${arg: int}=wrong
-    Fail    This shuld not be run
+Invalid default
+    [Arguments]    ${arg: int}=invalid
+    Should Be Equal    ${arg}    42    type=int
 
 Bad type
     [Arguments]    ${arg: bad}
diff --git a/src/robot/running/arguments/embedded.py b/src/robot/running/arguments/embedded.py
@@ -19,7 +19,7 @@
 
 from robot.errors import DataError
 from robot.utils import get_error_message
-from robot.variables import VariableMatch, VariableMatches
+from robot.variables import VariableMatches
 
 from ..context import EXECUTION_CONTEXTS
 from .typeinfo import TypeInfo
@@ -45,7 +45,7 @@ def __init__(
     def from_name(cls, name: str) -> "EmbeddedArguments|None":
         return EmbeddedArgumentParser().parse(name) if "${" in name else None
 
-    def match(self, name: str) -> 're.Match|None':
+    def match(self, name: str) -> "re.Match|None":
         """Deprecated since Robot Framework 7.3."""
         warnings.warn(
             "'EmbeddedArguments.match()' is deprecated since Robot Framework 7.3. Use "
@@ -87,7 +87,10 @@ def _replace_placeholders(self, arg: str, placeholders: "dict[str, str]") -> str
         return arg
 
     def map(self, args: Sequence[object]) -> "list[tuple[str, object]]":
-        args = [t.convert(a) if t else a for a, t in zip(args, self.types)]
+        args = [
+            info.convert(value, name) if info else value
+            for info, name, value in zip(self.types, self.args, args)
+        ]
         self.validate(args)
         return list(zip(self.args, args))
 
diff --git a/src/robot/running/userkeywordrunner.py b/src/robot/running/userkeywordrunner.py
@@ -138,7 +138,7 @@ def _set_variables(self, spec: ArgumentSpec, positional, named, variables):
                 value = value.resolve(variables)
                 info = spec.types.get(name)
                 if info:
-                    value = info.convert(value, name, kind="Argument default value")
+                    value = info.convert(value, name, kind="Default value for argument")
             variables[f"${{{name}}}"] = value
         if spec.var_positional:
             variables[f"@{{{spec.var_positional}}}"] = var_positional
