Features/hms #637
Draft
Features/hms #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thanks @khun84 for your help! Is there any plan to merge this PR? |
benlangfeld
reviewed
Sep 9, 2024
| add_column :rpush_apps, :hms_key_id, :string | ||
| add_column :rpush_apps, :hms_sub_acc_id, :string | ||
| add_column :rpush_apps, :hms_key, :string | ||
| add_column :rpush_notifications, :title, :string |
There was a problem hiding this comment.
Could you help me understand why this is required for HMS but not for other systems?
|
Hey! If we can get the tests passing and clear up the question about database schema changes, I'd like to get this moved forward. I'm going to leave the PR in draft status until then to indicate that it's waiting on further changes before being ready for a final review. |
|
@benlangfeld Thanks. Lots of thing happening on my end here recently. I will find time to address the comments, its been 2 years since I left it here 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As HMS is gaining more traction recently, especially in the Asia Pacific region, I've proposed (see #635) to introduce HMS as one of the supported push notification service in rpush.
As much as possible, the implementation strives to follow the existing code structure and I have been using it in production environment for more than 2 years.