Skip to content

Initial changes to prepare for SIG(0) #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Initial changes to prepare for SIG(0) #1202

wants to merge 1 commit into from

Conversation

jschlyter
Copy link
Contributor

  • Add shared RRSIGBase for code shared between RRSIG and SIG
  • Modify RRSIG to use RRSIGBase
  • Add KEY RR
  • Add SIG RR

@jschlyter
Initial changes to prepare for SIG(0):
a280a81 
- Add shared RRSIGBase for code shared between RRSIG and SIG
- Add KEY RR
- Add SIG RR
@bwelling
Copy link
Collaborator

I think all of this looks reasonable, but it's missing the differences between KEY and DNSKEY - KEY allows symbolic constants to be be used for the protocol and flags fields (https://www.rfc-editor.org/rfc/rfc2535#section-7.1), while DNSKEY (and dnspython's parser) does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschlyter @bwelling