ignore confirming belonging while finrializer

ko1 · ko1 · commit 43b76c6c8f00 · 2025-06-06T16:58:17.000+09:00
A finalizer registerred in Ractor A can be invoked in B.

```ruby
require "tempfile"
r = Ractor.new{
  10_000.times{|i|
    Tempfile.new(["file_to_require_from_ractor#{i}", ".rb"])
  }
}
sleep 0.1
```

For example, above script makes tempfiles which have finalizers
on Ractor r, but at the end of the process, main Ractor will invoke
finalizers and it violates belonging check. This patch just ignore
the belonging check to avoid CI failure.

Of course it violates Ractor's isolation and wrong workaround.
This issue will be solved with Ractor local GC.
diff --git a/gc.c b/gc.c
@@ -288,6 +288,7 @@ rb_gc_run_obj_finalizer(VALUE objid, long count, VALUE (*callback)(long i, void
     saved.finished = 0;
     saved.final = Qundef;
 
+    rb_ractor_ignore_belonging(true);
     EC_PUSH_TAG(ec);
     enum ruby_tag_type state = EC_EXEC_TAG();
     if (state != TAG_NONE) {
@@ -306,6 +307,7 @@ rb_gc_run_obj_finalizer(VALUE objid, long count, VALUE (*callback)(long i, void
         rb_check_funcall(saved.final, idCall, 1, &objid);
     }
     EC_POP_TAG();
+    rb_ractor_ignore_belonging(false);
 #undef RESTORE_FINALIZER
 }
 
diff --git a/ractor.c b/ractor.c
@@ -33,6 +33,11 @@ static VALUE rb_cRactorMovedObject;
 
 static void vm_ractor_blocking_cnt_inc(rb_vm_t *vm, rb_ractor_t *r, const char *file, int line);
 
+
+#if RACTOR_CHECK_MODE > 0
+bool ractor_ignore_belonging = false;
+#endif
+
 // Ractor locking
 
 static void
diff --git a/ractor_core.h b/ractor_core.h
@@ -266,9 +266,13 @@ rb_ractor_belonging(VALUE obj)
     }
 }
 
+extern bool ractor_ignore_belonging;
+
 static inline VALUE
 rb_ractor_confirm_belonging(VALUE obj)
 {
+    if (ractor_ignore_belonging) return obj;
+
     uint32_t id = rb_ractor_belonging(obj);
 
     if (id == 0) {
@@ -288,6 +292,14 @@ rb_ractor_confirm_belonging(VALUE obj)
     }
     return obj;
 }
+
+static inline void
+rb_ractor_ignore_belonging(bool flag)
+{
+    ractor_ignore_belonging = flag;
+}
+
 #else
 #define rb_ractor_confirm_belonging(obj) obj
+#define rb_ractor_ignore_belonging(flag) (0)
 #endif

Original file line number	Diff line number	Diff line change
`@@ -288,6 +288,7 @@ rb_gc_run_obj_finalizer(VALUE objid, long count, VALUE (*callback)(long i, void`
`288`	`288`	`saved.finished = 0;`
`289`	`289`	`saved.final = Qundef;`
`290`	`290`
	`291`	`+ rb_ractor_ignore_belonging(true);`
`291`	`292`	`EC_PUSH_TAG(ec);`
`292`	`293`	`enum ruby_tag_type state = EC_EXEC_TAG();`
`293`	`294`	`if (state != TAG_NONE) {`
`@@ -306,6 +307,7 @@ rb_gc_run_obj_finalizer(VALUE objid, long count, VALUE (*callback)(long i, void`
`306`	`307`	`rb_check_funcall(saved.final, idCall, 1, &objid);`
`307`	`308`	`}`
`308`	`309`	`EC_POP_TAG();`
	`310`	`+ rb_ractor_ignore_belonging(false);`
`309`	`311`	`#undef RESTORE_FINALIZER`
`310`	`312`	`}`
`311`	`313`
Original file line number	Diff line number	Diff line change
`@@ -266,9 +266,13 @@ rb_ractor_belonging(VALUE obj)`
`266`	`266`	`}`
`267`	`267`	`}`
`268`	`268`
	`269`	`+extern bool ractor_ignore_belonging;`
	`270`	`+`
`269`	`271`	`static inline VALUE`
`270`	`272`	`rb_ractor_confirm_belonging(VALUE obj)`
`271`	`273`	`{`
	`274`	`+ if (ractor_ignore_belonging) return obj;`
	`275`	`+`
`272`	`276`	`uint32_t id = rb_ractor_belonging(obj);`
`273`	`277`
`274`	`278`	`if (id == 0) {`
`@@ -288,6 +292,14 @@ rb_ractor_confirm_belonging(VALUE obj)`
`288`	`292`	`}`
`289`	`293`	`return obj;`
`290`	`294`	`}`
	`295`	`+`
	`296`	`+static inline void`
	`297`	`+rb_ractor_ignore_belonging(bool flag)`
	`298`	`+{`
	`299`	`+ ractor_ignore_belonging = flag;`
	`300`	`+}`
	`301`	`+`
`291`	`302`	`#else`
`292`	`303`	`#define rb_ractor_confirm_belonging(obj) obj`
	`304`	`+#define rb_ractor_ignore_belonging(flag) (0)`
`293`	`305`	`#endif`