Turn rb_classext_t.fields into a T_IMEMO/class_fields
#13411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
luke-gruber
reviewed
May 22, 2025
094b1e0 to
1055d42
Compare
|
Just to follow up because @byroot asked me to look at the JIT side of things. I don't think this impacts Z/YJIT because we only emit special machine code if the object is a T_OBJECT, everything else just uses |
|
Ah thanks! I'll dig more into why the JITs are failing tomorrow then. |
51398c3 to
defa987
Compare
7a42762 to
d594ee0
Compare
peterzhu2118
reviewed
Jun 3, 2025
ce2a8cd to
a701536
Compare
54f8834 to
a701141
Compare
8312c5c to
7065b2f
Compare
rb_classext_t.fields into a T_OBJECTrb_classext_t.fields into a T_IMEMO/class_fields
cb8b5be to
0cc94bd
Compare
This behave almost exactly as a T_OBJECT, the layout is entirely
compatible.
This aims to solve two problems.
First, it solves the problem of namspaced classes having
a single `shape_id`. Now each namespaced classext
has an object that can hold the namespace specific
shape.
Second, it open the door to later make class instance variable
writes atomics, hence be able to read class variables
without locking the VM.
In the future, in multi-ractor mode, we can do the write
on a copy of the `fields_obj` and then atomically swap it.
Considerations:
- Right now the `RClass` shape_id is always synchronized,
but with namespace we should likely mark classes that have
multiple namespace with a specific shape flag.
0cc94bd to
4449859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behave almost exactly as a T_OBJECT, the layout is entirely compatible.
This aims to solve two problems.
First, it solves the problem of namspaced classes having a single
shape_id.Now each namespaced classext has an object that can hold the namespace specific shape.
Second, it open the door to later make class instance variable writes atomics, hence be able to read class variables without locking the VM.
In the future, in multi-ractor mode, we can do the write on a copy of the
fields_objand then atomically swap it.Considerations:
RClassshape_id is always synchronized, but with namespace we should likely mark classes that have multiple namespace with a specific shape flag.