fix: fix Rubocop Naming/AccessorMethodName offense

jcouball · jcouball · commit e9d9c4f2488d · 2025-07-03T16:10:33.000-07:00
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -6,16 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 12
-# Configuration parameters: AllowedMethods, AllowedPatterns.
-Metrics/PerceivedComplexity:
-  Max: 22
-
-# Offense count: 1
-Naming/AccessorMethodName:
-  Exclude:
-    - 'lib/git/object.rb'
-
 # Offense count: 1
 # Configuration parameters: ForbiddenDelimiters.
 # ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
@@ -110,3 +100,8 @@ Metrics/CyclomaticComplexity:
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 51
+
+# Offense count: 12
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Metrics/PerceivedComplexity:
+  Max: 22
diff --git a/lib/git/object.rb b/lib/git/object.rb
@@ -159,7 +159,7 @@ def initialize(base, sha, init = nil)
         @message = nil
         return unless init
 
-        set_commit(init)
+        from_data(init)
       end
 
       def message
@@ -211,7 +211,12 @@ def diff_parent
         diff(parent)
       end
 
-      def set_commit(data)
+      def set_commit(data) # rubocop:disable Naming/AccessorMethodName
+        Git.deprecation('Git::Object::Commit#set_commit is deprecated. Use #from_data instead.')
+        from_data(data)
+      end
+
+      def from_data(data)
         @sha ||= data['sha']
         @committer = Git::Author.new(data['committer'])
         @author = Git::Author.new(data['author'])
@@ -231,7 +236,7 @@ def check_commit
         return if @tree
 
         data = @base.lib.cat_file_commit(@objectish)
-        set_commit(data)
+        from_data(data)
       end
     end
 
