Address #7

zetachang · zetachang · commit 05f24bd89baf · 2015-02-25T21:29:58.000+08:00
diff --git a/lib/react/component.rb b/lib/react/component.rb
@@ -69,15 +69,27 @@ def component_will_unmount
       self.run_callback(:before_unmount)
     end
 
+    def p(*args, &block)
+      if block || args.count == 0 || (args.count == 1 && args.first.is_a?(Hash))
+        _p_tag(*args, &block)
+      else
+        Kernel.p(*args)
+      end
+    end
+
     def method_missing(name, *args, &block)
-      unless (React::HTML_TAGS.include?(name) || name == 'present')
+      unless (React::HTML_TAGS.include?(name) || name == 'present' || name == '_p_tag')
         return super
       end
 
       if name == "present"
         name = args.shift
       end
 
+      if name == "_p_tag"
+        name = "p"
+      end
+
       @buffer = [] unless @buffer
       if block
         current = @buffer
diff --git a/spec/component_spec.rb b/spec/component_spec.rb
@@ -536,6 +536,47 @@ def render
       element = React.create_element(Foo)
       expect(React.render_to_static_markup(element)).to eq("<div></div>")
     end
+
+    it "should redefine `p` to make method missing work" do
+      stub_const 'Foo', Class.new
+      Foo.class_eval do
+        include React::Component
+
+        def render
+          p(class_name: "foo") do
+            p
+            div { "lorem ipsum" }
+            p(id: "10")
+          end
+        end
+      end
+
+      element = React.create_element(Foo)
+      expect(React.render_to_static_markup(element)).to eq("<p class=\"foo\"><p></p><div>lorem ipsum</div><p id=\"10\"></p></p>")
+    end
+
+    it "should only override `p` in render context" do
+      stub_const 'Foo', Class.new
+      Foo.class_eval do
+        include React::Component
+
+        before_mount do
+          p "first"
+        end
+
+        after_mount do
+          p "second"
+        end
+
+        def render
+          div
+        end
+      end
+
+      expect(Kernel).to receive(:p).with("first")
+      expect(Kernel).to receive(:p).with("second")
+      renderToDocument(Foo)
+    end
   end
 
   describe "isMounted()" do
