React#create_element accept a native component constructor function

zetachang · zetachang · commit 16eaf322f7c9 · 2015-04-12T15:20:27.000+08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## 0.3.0 (Edge)
 *  Set `displayName` of component as the Ruby class name, which make it displayed better in [react-devtools](https://github.com/facebook/react-devtools)
 *  Fix React::Element bridging in React Native environment (#fba2daeb)
+*  React#create_element accept a native component constructor function
 
 ## 0.2.1
 *  Depends on opal `~> 0.6.0`, which accidentally got loosen in previous release
diff --git a/lib/react/api.rb b/lib/react/api.rb
@@ -6,7 +6,9 @@ def self.create_element(type, properties = {}, &block)
       params = []
 
       # Component Spec or Nomral DOM
-      if type.kind_of?(Class)
+      if `(typeof type === 'function')`
+        params << type
+      elsif type.kind_of?(Class)
         raise "Provided class should define `render` method"  if !(type.method_defined? :render)
         params << self.native_component_class(type)
       else
diff --git a/spec/react_spec.rb b/spec/react_spec.rb
@@ -22,6 +22,16 @@
       element = React.create_element('div')
       expect(React.is_valid_element(element)).to eq(true)
     end
+    
+    it "should allow passed a React.Component class (constructor function)" do
+      hello_message = `React.createClass({displayName: "HelloMessage",
+        render: function() {
+            return React.createElement("div", null, "Hello ", this.props.name);
+        }
+      });`
+      element = React.create_element(hello_message, name: "David")
+      expect(React.render_to_static_markup(element)).to eq('<div>Hello David</div>')
+    end
 
     context "with block" do
       it "should create a valid element with text as only child when block yield String" do
