Only camelize default attributes

zetachang · zetachang · commit 5de8c5ce9782 · 2015-02-22T21:06:24.000+08:00
diff --git a/lib/react/api.rb b/lib/react/api.rb
@@ -64,7 +64,7 @@ def self.create_element(type, properties = {}, &block)
          if key == "class_name" && value.is_a?(Hash)
            props[lower_camelize(key)] = `React.addons.classSet(#{value.to_n})`
          else
-           props[lower_camelize(key)] = value
+           props[React::ATTRIBUTES.include?(lower_camelize(key)) ? lower_camelize(key) : key] = value
          end
       end
       params << props
diff --git a/lib/react/top_level.rb b/lib/react/top_level.rb
@@ -21,7 +21,7 @@ module React
                 muted name noValidate open pattern placeholder poster preload radioGroup
                 readOnly rel required role rows rowSpan sandbox scope scrolling seamless
                 selected shape size sizes span spellCheck src srcDoc srcSet start step style
-                tabIndex target title type useMap value width wmode)
+                tabIndex target title type useMap value width wmode dangerously_set_inner_HTML)
 
   def self.create_element(type, properties = {}, &block)
     React::API.create_element(type, properties, &block)
diff --git a/spec/react_spec.rb b/spec/react_spec.rb
@@ -91,6 +91,11 @@ def render
         element = React.create_element("div", foo: "bar")
         expect(element.props.foo).to eq("bar")
       end
+
+      it "should not camel-case custom property" do
+        element = React.create_element("div", foo_bar: "foo")
+        expect(element.props.foo_bar).to eq("foo")
+      end
     end
 
     describe "class_name helpers (React.addons.classSet)" do
