Skip to content

Commit 135059a

Browse files
committed
[test] fix crash dump report for windows
1 parent 9465d67 commit 135059a

File tree

1 file changed

+11
-8
lines changed
  • test/sanity/crash-dump-report

1 file changed

+11
-8
lines changed

test/sanity/crash-dump-report/test.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -91,20 +91,23 @@ def copytree(src, dst, symlinks=False, ignore=None):
9191
''' % (pkgname, server.port))
9292
manifest.close()
9393

94+
if os.path.exists(user_data_dir):
95+
time.sleep(7)
96+
shutil.rmtree(user_data_dir)
9497
assert not os.path.exists(user_data_dir), "'%s' should not be existed before testing" % user_data_dir
9598

9699
p = subprocess.Popen([exe, arg])
97100
_LOGGER.info('Waiting for crash report')
98101
try:
99-
if not server.wait_for_report(10):
102+
if not server.wait_for_report(18):
100103
raise Exception('No report received.')
101104
finally:
102105
p.terminate()
103-
r = server.crash(0)
104-
report.LogCrashKeys(r)
105-
ptype = r['ptype'][0]
106-
assert(ptype == 'browser' and arg == '--test-browser-crash' or ptype in ['renderer', 'extension'] and arg == '--test-renderer-crash')
107-
assert(pkgname == r['prod'][0])
108-
assert(r['ver'][0] == "0.0.12")
109-
assert(len(r['upload_file_minidump'][0]) > 100000)
106+
r = server.crash(0)
107+
report.LogCrashKeys(r)
108+
ptype = r['ptype'][0]
109+
assert(ptype == 'browser' and arg == '--test-browser-crash' or ptype in ['renderer', 'extension'] and arg == '--test-renderer-crash')
110+
assert(pkgname == r['prod'][0])
111+
assert(r['ver'][0] == "0.0.12")
112+
assert(len(r['upload_file_minidump'][0]) > 100000)
110113

0 commit comments

Comments
 (0)