Skip to content

Commit 61eed7d

Browse files
committed
[test] fix race condition in zoom-all test
1 parent ee988a6 commit 61eed7d

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

test/sanity/issue4352-zoom-all/index.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<body>
66
<div id='result'>zoom level</div>
77
<script>
8+
window.name = 'index';
89
function test(val) {
910
document.getElementById('result').innerHTML = val;
1011
}

test/sanity/issue4352-zoom-all/popup.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<body>
66
<div id='result'>zoom level</div>
77
<script>
8+
window.name = 'popup';
89
nw.Window.get().zoomLevel = 2;
910
setTimeout(function() {
1011
document.getElementById('result').innerHTML = window.devicePixelRatio;

test/sanity/issue4352-zoom-all/test.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
import time
22
import os
3+
import sys
4+
sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
5+
from nw_util import *
36

47
from selenium import webdriver
58
from selenium.webdriver.chrome.options import Options
@@ -10,14 +13,15 @@
1013
driver.implicitly_wait(5)
1114
time.sleep(1)
1215
try:
16+
wait_window_handles(driver, 2)
17+
wait_switch_window_name(driver, 'popup')
1318
print driver.current_url
14-
driver.switch_to_window(driver.window_handles[-1])
1519
zoom2 = 'zoom level'
1620
while zoom2 == 'zoom level':
1721
zoom2 = driver.find_element_by_id('result').get_attribute('innerHTML')
1822
time.sleep(1)
1923
print "zoom2: ", zoom2
20-
driver.switch_to_window(driver.window_handles[0])
24+
wait_switch_window_name(driver, 'index')
2125
driver.find_element_by_id('get-zoom').click()
2226
zoom1 = driver.find_element_by_id('result').get_attribute('innerHTML')
2327
print "zoom1: ", zoom1

0 commit comments

Comments
 (0)