Fix nwjs#6143: Crash when called window nw.Window.get().setProgessBar()

rogerwang · rogerwang · commit 70e7ae8994de · 2017-09-20T12:57:11.000+08:00
diff --git a/src/api/nw_window_api_mac.mm b/src/api/nw_window_api_mac.mm
@@ -78,8 +78,8 @@ - (void)drawRect:(NSRect)dirtyRect {
   EXTENSION_FUNCTION_VALIDATE(args_->GetDouble(0, &progress));
   NSDockTile *dockTile = [NSApp dockTile];
   NWProgressBar *progressIndicator = NULL;
-  
-  if (dockTile.contentView == NULL && progress >= 0) {
+
+  if ((dockTile.contentView == NULL || [dockTile.contentView.subviews count] == 0 )&& progress >= 0) {
     
     // create image view to draw application icon
     NSImageView *iv = [[NSImageView alloc] init];
@@ -125,6 +125,7 @@ - (void)drawRect:(NSRect)dirtyRect {
   }
   
   [dockTile display];
+  SendResponse(true);
   return true;
 }
 
