[OSX] Free Window object when closing CDT

rogerwang · rogerwang · commit 9e08a6f42986 · 2013-12-18T14:19:51.000+08:00
Fix nwjs#1391
diff --git a/src/nw_shell.cc b/src/nw_shell.cc
@@ -188,6 +188,13 @@ Shell::~Shell() {
     if (devtools_owner_->devtools_window_id_) {
       dhost->OnDeallocateObject(devtools_owner_->devtools_window_id_);
       devtools_owner_->devtools_window_id_ = 0;
+    }else if (id_) {
+      //FIXME: the ownership/ flow of window and shell destruction
+      //need to be cleared
+
+      // In linux, Shell destruction will be called immediately in
+      // CloseDevTools but in OSX it won't
+      dhost->OnDeallocateObject(id_);
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,13 @@ Shell::~Shell() {`
`188`	`188`	`if (devtools_owner_->devtools_window_id_) {`
`189`	`189`	`dhost->OnDeallocateObject(devtools_owner_->devtools_window_id_);`
`190`	`190`	`devtools_owner_->devtools_window_id_ = 0;`
	`191`	`+ }else if (id_) {`
	`192`	`+ //FIXME: the ownership/ flow of window and shell destruction`
	`193`	`+ //need to be cleared`
	`194`	`+`
	`195`	`+ // In linux, Shell destruction will be called immediately in`
	`196`	`+ // CloseDevTools but in OSX it won't`
	`197`	`+ dhost->OnDeallocateObject(id_);`
`191`	`198`	`}`
`192`	`199`	`}`
`193`	`200`