Add support for nwWindow.setShadow(bool) on Mac

Jahanzeb Sherwani · rogerwang · commit b87762facf64 · 2018-04-27T12:59:10.000+08:00
diff --git a/src/api/nw_current_window_internal.idl b/src/api/nw_current_window_internal.idl
@@ -23,6 +23,7 @@ namespace nw.currentWindowInternal {
 
   interface Functions {
     static void close(optional boolean force);
+    static void setShadow(boolean shadow);
     static void showDevToolsInternal(optional ShowDevToolsCallback callback);
     static void closeDevTools();
     static void setBadgeLabel(DOMString badge);
diff --git a/src/api/nw_window_api.cc b/src/api/nw_window_api.cc
@@ -621,6 +621,17 @@ bool NwCurrentWindowInternalGetTitleInternalFunction::RunNWSync(base::ListValue*
   return true;
 }
 
+bool NwCurrentWindowInternalSetShadowFunction::RunAsync() {
+#if defined(OS_MACOSX)
+  EXTENSION_FUNCTION_VALIDATE(args_);
+  bool shadow;
+  EXTENSION_FUNCTION_VALIDATE(args_->GetBoolean(0, &shadow));
+  AppWindow* window = getAppWindow(this);
+  SetShadowOnWindow(window->GetNativeWindow(), shadow);
+#endif
+  return true;
+}
+
 bool NwCurrentWindowInternalSetTitleInternalFunction::RunNWSync(base::ListValue* response, std::string* error) {
   EXTENSION_FUNCTION_VALIDATE(args_);
   std::string title;
diff --git a/src/api/nw_window_api.h b/src/api/nw_window_api.h
@@ -120,6 +120,19 @@ class NwCurrentWindowInternalSetMenuFunction : public NWSyncExtensionFunction {
   DISALLOW_COPY_AND_ASSIGN(NwCurrentWindowInternalSetMenuFunction);
 };
 
+class NwCurrentWindowInternalSetShadowFunction : public AsyncExtensionFunction {
+ public:
+  NwCurrentWindowInternalSetShadowFunction(){}
+
+ protected:
+  ~NwCurrentWindowInternalSetShadowFunction() override {}
+  void SetShadowOnWindow(NSWindow *window, bool shadow);
+
+  // ExtensionFunction:
+  bool RunAsync() override;
+  DECLARE_EXTENSION_FUNCTION("nw.currentWindowInternal.setShadow", UNKNOWN)
+};
+
 class NwCurrentWindowInternalSetBadgeLabelFunction : public AsyncExtensionFunction {
  public:
   NwCurrentWindowInternalSetBadgeLabelFunction(){}
diff --git a/src/api/nw_window_api_mac.mm b/src/api/nw_window_api_mac.mm
@@ -8,6 +8,7 @@
 #import <Appkit/NSDocktile.h>
 #import <Appkit/NSImageView.h>
 #import <Appkit/NSProgressIndicator.h>
+#import <Appkit/NSWindow.h>
 
 @interface NWProgressBar : NSProgressIndicator
 @end
@@ -44,7 +45,11 @@ - (void)drawRect:(NSRect)dirtyRect {
 @end
 
 namespace extensions {
-  
+
+void NwCurrentWindowInternalSetShadowFunction::SetShadowOnWindow(NSWindow *window, bool shadow) {
+  window.hasShadow = shadow;
+}
+
 bool NwCurrentWindowInternalSetBadgeLabelFunction::RunAsync() {
   EXTENSION_FUNCTION_VALIDATE(args_);
   std::string badge;
diff --git a/src/resources/api_nw_window.js b/src/resources/api_nw_window.js
@@ -379,6 +379,10 @@ nw_binding.registerCustomHook(function(bindingsAPI) {
       return this;
     };
 
+    NWWindow.prototype.setShadow = function(shadow) {
+      currentNWWindowInternal.setShadow(shadow);
+    }
+
     NWWindow.prototype.showDevTools = function(frm, callback) {
       var id = '';
       if (typeof frm === 'string')
