Fixed ConvertToAbsolutePath to return a absolute path

Cong Liu · rogerwang · commit bca9c7d0a6eb · 2016-11-04T10:57:19.000+08:00
When starting apps from a folder of parent, such as `nw ../app_root/`, icon file cannot be loaded correctly. The root cause is that `base::ReadFileToString` refused for path referencing to parent folder. However path of icon obtained by `nw::Package::ConvertToAbsolutePath` is still a relative path. The patch fixes `ConvertToAbsolutePath` to return a absolute path. fixed nwjs#5402
diff --git a/src/nw_package.cc b/src/nw_package.cc
@@ -235,7 +235,7 @@ FilePath Package::ConvertToAbsoutePath(const FilePath& path) {
   if (path.IsAbsolute())
     return path;
 
-  return this->path().Append(path);
+  return MakeAbsoluteFilePath(this->path()).Append(path);
 }
 
 GURL Package::GetStartupURL() {

Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,7 @@ FilePath Package::ConvertToAbsoutePath(const FilePath& path) {`
`235`	`235`	`if (path.IsAbsolute())`
`236`	`236`	`return path;`
`237`	`237`
`238`		`- return this->path().Append(path);`
	`238`	`+ return MakeAbsoluteFilePath(this->path()).Append(path);`
`239`	`239`	`}`
`240`	`240`
`241`	`241`	`GURL Package::GetStartupURL() {`