perf: fix eslint warning

PanJiaChen · PanJiaChen · commit 81a44a02845b · 2019-10-09T21:12:03.000+08:00
diff --git a/src/components/ImageCropper/index.vue b/src/components/ImageCropper/index.vue
@@ -248,7 +248,8 @@ export default {
       // 浏览器是否支持该控件
       isSupported,
       // 浏览器是否支持触屏事件
-      isSupportTouch: document.hasOwnProperty('ontouchstart'),
+
+      isSupportTouch: Object.prototype.hasOwnProperty.call(document, 'ontouchstart'),
       // 步骤
       step: 1, // 1选择文件 2剪裁 3上传
       // 上传状态及进度
diff --git a/src/store/modules/settings.js b/src/store/modules/settings.js
@@ -13,7 +13,8 @@ const state = {
 
 const mutations = {
   CHANGE_SETTING: (state, { key, value }) => {
-    if (state.hasOwnProperty(key)) {
+    // https://eslint.org/docs/rules/no-prototype-builtins
+    if (Object.prototype.hasOwnProperty.call(state, key)) {
       state[key] = value
     }
   }
diff --git a/src/store/modules/user.js b/src/store/modules/user.js
@@ -104,6 +104,7 @@ const actions = {
 
   // dynamically modify permissions
   changeRoles({ commit, dispatch }, role) {
+    // eslint-disable-next-line
     return new Promise(async resolve => {
       const token = role + '-token'
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,8 @@ const state = {`
`13`	`13`
`14`	`14`	`const mutations = {`
`15`	`15`	`CHANGE_SETTING: (state, { key, value }) => {`
`16`		`- if (state.hasOwnProperty(key)) {`
	`16`	`+ // https://eslint.org/docs/rules/no-prototype-builtins`
	`17`	`+ if (Object.prototype.hasOwnProperty.call(state, key)) {`
`17`	`18`	`state[key] = value`
`18`	`19`	`}`
`19`	`20`	`}`