Skip to content

Use triomphe::ThinArc in TokenStream. #146082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use triomphe::ThinArc in TokenStream. #146082

wants to merge 1 commit into from

Conversation

nnethercote
Copy link
Contributor

r? @ghost

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 1, 2025
@nnethercote
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 1, 2025
@rust-bors
Auto merge of #146082 - nnethercote:triomphe-extending, r=<try>
0b2a374 
Use `triomphe::ThinArc` in `TokenStream`.
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 1, 2025
@rust-bors
Copy link

rust-bors bot commented Sep 1, 2025

☀️ Try build successful (CI)
Build commit: 0b2a374 (0b2a374f3806cd948b6307fe6094ab731eda5de3, parent: be4e9b77ab5502b7beda0b787fb3c978a7b4db79)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0b2a374): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.4% [0.1%, 1.2%] 111
Regressions ❌
(secondary)		 0.8% [0.0%, 5.4%] 78
Improvements ✅
(primary)		 -0.5% [-0.7%, -0.3%] 4
Improvements ✅
(secondary)		 -0.2% [-0.2%, -0.1%] 8
All ❌✅ (primary) 0.4% [-0.7%, 1.2%] 115

Max RSS (memory usage)

Results (primary -1.7%, secondary -1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.8% [1.1%, 4.7%] 12
Improvements ✅
(primary)		 -1.7% [-2.5%, -0.9%] 44
Improvements ✅
(secondary)		 -4.6% [-10.7%, -1.4%] 19
All ❌✅ (primary) -1.7% [-2.5%, -0.9%] 44

Cycles

Results (secondary -6.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.9% [2.0%, 3.9%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -9.6% [-13.0%, -3.1%] 5
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.792s -> 466.644s (-0.46%)
Artifact size: 388.52 MiB -> 388.70 MiB (0.05%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 1, 2025
@nnethercote nnethercote closed this Sep 2, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-tidy Area: The tidy tool perf-regression Performance regression. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnethercote @rust-timer @rustbot